Skip to content

Conversation

@iinuwa
Copy link

@iinuwa iinuwa commented Oct 29, 2025

⚠️ This is a draft PR for discussing a proof-of-concept. Detailed review should not be done until this work is refined.

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27582
https://bitwarden.atlassian.net/browse/PM-26177

📔 Objective

This PR adds the ability to create and use what we're calling a "device auth key" to sign-in using the Bitwarden app. This is a draft PR for a

This depends on:

📸 Screenshots

New Account Setting: Unlock other devices with this device Demonstration of vault sign-in prompt with iOS passkey autofill

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Logo
Checkmarx One – Scan Summary & Details46c86e20-5b87-4828-a268-678e3ae45e81

Great job! No new security vulnerabilities introduced in this pull request

@iinuwa iinuwa force-pushed the iinuwa/independent-device-bound-unlock-passkey branch from 0306564 to 07d808b Compare January 5, 2026 22:18
@iinuwa iinuwa changed the base branch from main to iinuwa/update-passkey-rs January 5, 2026 22:19
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.55%. Comparing base (57f3f0e) to head (bc7bc04).

Files with missing lines Patch % Lines
BitwardenKit/Core/Platform/Extensions/Data.swift 0.00% 17 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           iinuwa/update-passkey-rs    #2082      +/-   ##
============================================================
- Coverage                     43.58%   43.55%   -0.03%     
============================================================
  Files                           584      584              
  Lines                         30505    30522      +17     
============================================================
  Hits                          13295    13295              
- Misses                        17210    17227      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iinuwa iinuwa force-pushed the iinuwa/independent-device-bound-unlock-passkey branch from bc7bc04 to fe5deba Compare January 26, 2026 15:35
@iinuwa iinuwa changed the base branch from iinuwa/update-passkey-rs to main January 26, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants