Skip to content

Revert review Code Triggered by labeled event#250

Merged
theMickster merged 1 commit intomainfrom
ai/revert-claude-review-labeled-trigger
Dec 31, 2025
Merged

Revert review Code Triggered by labeled event#250
theMickster merged 1 commit intomainfrom
ai/revert-claude-review-labeled-trigger

Conversation

@theMickster
Copy link
Contributor

🎟️ Tracking

📔 Objective

Refactor pull request trigger types to those supported by Anthropic's Claude Code

@theMickster theMickster requested a review from a team as a code owner December 31, 2025 15:55
@theMickster theMickster added the ai-review Request a Claude code review label Dec 31, 2025
@theMickster theMickster enabled auto-merge (squash) December 31, 2025 15:55
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.04%. Comparing base (32241c1) to head (ea3d726).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #250   +/-   ##
=====================================
  Coverage   7.04%   7.04%           
=====================================
  Files         49      49           
  Lines       1818    1818           
  Branches      99      99           
=====================================
  Hits         128     128           
  Misses      1685    1685           
  Partials       5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theMickster theMickster merged commit 9dc5596 into main Dec 31, 2025
12 of 14 checks passed
@theMickster theMickster deleted the ai/revert-claude-review-labeled-trigger branch December 31, 2025 15:56
on:
pull_request:
types: [opened, labeled]
types: [opened, synchronize, reopened]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ IMPORTANT: Revert removes ready_for_review trigger, creating gap in review workflow

Details and fix

This revert changes the trigger from the original [opened, synchronize, reopened, ready_for_review] to [opened, synchronize, reopened], removing the ready_for_review event.

Impact:

  • Draft PRs marked "ready for review" will not trigger the code review workflow
  • Reviews will only run when new commits are pushed (synchronize)
  • Creates a gap where PRs can bypass automated review

Execution path demonstrating the issue:

  1. Developer creates draft PR → no review (correct, draft PRs shouldn't be reviewed)
  2. Developer marks PR as "ready for review" → no review (MISSING - should trigger)
  3. Only when next commit is pushed will review workflow run

Recommended fix:

Suggested change
types: [opened, synchronize, reopened]
types: [opened, synchronize, reopened, ready_for_review]

This restores the original behavior while correctly reverting the labeled trigger that was causing issues.

Reference: GitHub Actions pull_request events

@claude
Copy link

claude bot commented Dec 31, 2025

Overall Assessment: REQUEST CHANGES

This PR reverts the workflow trigger from [opened, labeled] back to [opened, synchronize, reopened]. However, the revert inadvertently removes the ready_for_review trigger that was present in the original configuration before PR #249.

Code Review Details
  • ⚠️ IMPORTANT: Revert removes ready_for_review trigger, creating gap in review workflow
    • .github/workflows/review-code.yml:5

🤖 Generated with Claude Code

Review powered by Bitwarden Code Review Agent • Feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants