Revert review Code Triggered by labeled event#250
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=====================================
Coverage 7.04% 7.04%
=====================================
Files 49 49
Lines 1818 1818
Branches 99 99
=====================================
Hits 128 128
Misses 1685 1685
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| on: | ||
| pull_request: | ||
| types: [opened, labeled] | ||
| types: [opened, synchronize, reopened] |
There was a problem hiding this comment.
ready_for_review trigger, creating gap in review workflow
Details and fix
This revert changes the trigger from the original [opened, synchronize, reopened, ready_for_review] to [opened, synchronize, reopened], removing the ready_for_review event.
Impact:
- Draft PRs marked "ready for review" will not trigger the code review workflow
- Reviews will only run when new commits are pushed (
synchronize) - Creates a gap where PRs can bypass automated review
Execution path demonstrating the issue:
- Developer creates draft PR → no review (correct, draft PRs shouldn't be reviewed)
- Developer marks PR as "ready for review" → no review (MISSING - should trigger)
- Only when next commit is pushed will review workflow run
Recommended fix:
| types: [opened, synchronize, reopened] | |
| types: [opened, synchronize, reopened, ready_for_review] |
This restores the original behavior while correctly reverting the labeled trigger that was causing issues.
Reference: GitHub Actions pull_request events
|
Overall Assessment: REQUEST CHANGES This PR reverts the workflow trigger from Code Review Details
🤖 Generated with Claude Code Review powered by Bitwarden Code Review Agent • Feedback |
🎟️ Tracking
📔 Objective
Refactor pull request trigger types to those supported by Anthropic's Claude Code