Skip to content

Revert review Code Triggered by labeled event #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theMickster merged 1 commit into from
Dec 31, 2025
Merged

Revert review Code Triggered by labeled event #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/review-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Code Review

on:
pull_request:
types: [opened, labeled]
types: [opened, synchronize, reopened]
Copy link

@claude claude bot Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ IMPORTANT: Revert removes ready_for_review trigger, creating gap in review workflow

Details and fix

This revert changes the trigger from the original [opened, synchronize, reopened, ready_for_review] to [opened, synchronize, reopened], removing the ready_for_review event.

Impact:

  • Draft PRs marked "ready for review" will not trigger the code review workflow
  • Reviews will only run when new commits are pushed (synchronize)
  • Creates a gap where PRs can bypass automated review

Execution path demonstrating the issue:

  1. Developer creates draft PR → no review (correct, draft PRs shouldn't be reviewed)
  2. Developer marks PR as "ready for review" → no review (MISSING - should trigger)
  3. Only when next commit is pushed will review workflow run

Recommended fix:

Suggested change
types: [opened, synchronize, reopened]
types: [opened, synchronize, reopened, ready_for_review]

This restores the original behavior while correctly reverting the labeled trigger that was causing issues.

Reference: GitHub Actions pull_request events


permissions: {}

Expand Down
Loading