-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-21918] update send api models to support new email field
#5895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5895 +/- ##
==========================================
+ Coverage 58.58% 58.72% +0.14%
==========================================
Files 1920 1922 +2
Lines 85264 85328 +64
Branches 7632 7649 +17
==========================================
+ Hits 49953 50112 +159
+ Misses 33465 33356 -109
- Partials 1846 1860 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jaasen-livefront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve vault change
…com:bitwarden/server into tools/pm-21918/send-authentication-commands merge latest from main
| -- in 2 server releases | ||
| @Emails NVARCHAR(1024) = NULL | ||
| @Emails NVARCHAR(4000) = NULL, | ||
| @AuthType TINYINT = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value should be NULL
| @AuthType TINYINT = 2 | |
| @AuthType TINYINT = NULL |
| @CipherId UNIQUEIDENTIFIER = NULL, | ||
| @Emails NVARCHAR(1024) = NULL | ||
| @Emails NVARCHAR(4000) = NULL, | ||
| @AuthType TINYINT = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value should be NULL
| @AuthType TINYINT = 2 | |
| @AuthType TINYINT = NULL |
mkincaid-bw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the updates now, LGTM
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21918
https://bitwarden.atlassian.net/browse/PM-29783
https://bitwarden.atlassian.net/browse/PM-29789
https://bitwarden.atlassian.net/wiki/spaces/EN/pages/2164654083/Email-authenticated+Sends+-+Updated
Implements #5895
📔 Objective
Original
Update send API models to support email/OTP administration.
Important
This PR includes documentation for the related models. I mostly inferred what each of these are. Please focus on them during review to confirm that the comments are correct.
Updated
In a recent tech breakdown it was decided we would also add an explicit property
AuthTypethat will allow the client to determine the authentication strategy to use (email OTP, password, or none) without relying on the presence or absence ofEmailsorPasswordproperties in order to infer the strategy. The latest iteration of this PR accomplishes the following:AuthTypeproperty is not setEmailswere also updated to include theAuthTypepropertyFIXMEswere addressed: One overload ofToSendwas renamed toUpdateSendandGlobalSettingswere eliminated from one of the updated filesAuthTypeinference, explicit assignment, and other behavior not formerly covered inSendsController⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes