-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Move all event integration code to Dirt #6757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @brant-livefront's task in 2m 56s —— View job Code Review Complete
The code review has been completed. All findings have been posted as inline comments and a summary review comment. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6757 +/- ##
==========================================
+ Coverage 54.74% 58.58% +3.84%
==========================================
Files 1920 1920
Lines 85226 85226
Branches 7626 7626
==========================================
+ Hits 46654 49930 +3276
+ Misses 36798 33450 -3348
- Partials 1774 1846 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
withinfocus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet format. Also please note that we need to fix any links to that readme once this lands.
|
@withinfocus format in the latest commit. 👍 I've got the link on my list of things to do - I noticed that when doing the latest contributing docs updates and we'd have had to change the link anyway since it's moving locations. 👍 I think that's the only link out there. |
603ef8d


📔 Objective
This PR moves all of the event integrations code to Dirt. There should not be any code changes, other than the necessary cleanup of some of the import statements. A few files are erroneously showing as deleted instead of renamed, but I did legitimately delete one file - the interface for our old in-memory cache which is no longer used.
I've also moved the README to a more optimal location. It was way down under services. But now that we have an event integrations folder at the top with the service collection extension in it, it seemed like a much more direct place to put it.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes