Skip to content

Conversation

@brant-livefront
Copy link
Contributor

📔 Objective

This PR moves all of the event integrations code to Dirt. There should not be any code changes, other than the necessary cleanup of some of the import statements. A few files are erroneously showing as deleted instead of renamed, but I did legitimately delete one file - the interface for our old in-memory cache which is no longer used.

I've also moved the README to a more optimal location. It was way down under services. But now that we have an event integrations folder at the top with the service collection extension in it, it seemed like a much more direct place to put it.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@claude
Copy link
Contributor

claude bot commented Dec 18, 2025

Claude finished @brant-livefront's task in 2m 56s —— View job


Code Review Complete

  • Launching code review agent
  • Analyzing changes
  • Posting findings

The code review has been completed. All findings have been posted as inline comments and a summary review comment.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.58%. Comparing base (67534e2) to head (603ef8d).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...tyFramework/Dirt/Models/OrganizationIntegration.cs 80.00% 1 Missing ⚠️
...irt/Models/OrganizationIntegrationConfiguration.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6757      +/-   ##
==========================================
+ Coverage   54.74%   58.58%   +3.84%     
==========================================
  Files        1920     1920              
  Lines       85226    85226              
  Branches     7626     7626              
==========================================
+ Hits        46654    49930    +3276     
+ Misses      36798    33450    -3348     
- Partials     1774     1846      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Logo
Checkmarx One – Scan Summary & Details55b46beb-b783-481d-8341-78185c3f6a28

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1170
detailsMethod at line 1170 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
ID: ydwqMeYmBkmGAeG%2FbyXCmFNSIz4%3D
Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1060
detailsMethod at line 1060 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
ID: NBqS3wtj%2BwcjukpYL1K2xj0Y2Fw%3D
Attack Vector

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet format. Also please note that we need to fix any links to that readme once this lands.

@brant-livefront
Copy link
Contributor Author

@withinfocus format in the latest commit. 👍

I've got the link on my list of things to do - I noticed that when doing the latest contributing docs updates and we'd have had to change the link anyway since it's moving locations. 👍 I think that's the only link out there.

withinfocus
withinfocus previously approved these changes Dec 19, 2025
r-tome
r-tome previously approved these changes Dec 19, 2025
JimmyVo16
JimmyVo16 previously approved these changes Dec 19, 2025
@brant-livefront brant-livefront merged commit 86a68ab into main Dec 30, 2025
56 of 57 checks passed
@brant-livefront brant-livefront deleted the brant/move-event-integrations-to-dirt branch December 30, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants