Skip to content

fix: update emails for advocate and applicant#5897

Merged
KrissDrawing merged 15 commits intomainfrom
5667/Housing-advocate-Application-email-changes
Feb 27, 2026
Merged

fix: update emails for advocate and applicant#5897
KrissDrawing merged 15 commits intomainfrom
5667/Housing-advocate-Application-email-changes

Conversation

@KrissDrawing
Copy link
Collaborator

@KrissDrawing KrissDrawing commented Feb 17, 2026

This PR addresses #5667

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds alternate email copy for advocate, also sends 2 emails when both email addresses provided.
Now im not sure if for applicant we should display advocate email (this unanswered comment).
Not sure if i should update link to redirect to /account/applications instead of login page 🤔
Also not sure how it works with new languages, does it make sense to add them to migration, not sure if they are present in DB.
And kind of missed whole confirmation part of this task. But at this point not sure what should be changed there

How Can This Be Tested/Reviewed?

Run migration. Create application with email address and alternate contact email address. On database set isAdvocate to true for alternate contact email user. Update application with waitlist number changes. It should send email. Check how it behaves for different languages (on local we might have just es). It should work as before for isAdvocate set to false.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Feb 17, 2026
@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 8b82f72
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69a196c6e65a330008df03dc
😎 Deploy Preview https://deploy-preview-5897--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 8b82f72
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69a196c6f183640008baa003

@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 8b82f72
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/69a196c67a394f0008e8dba9
😎 Deploy Preview https://deploy-preview-5897--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for partners-bloom-msq2 canceled.

Name Link
🔨 Latest commit 8b82f72
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-msq2/deploys/69a196c6b1fd7200077ce1fc

@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 8b82f72
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/69a196c6756cc30009073ce0
😎 Deploy Preview https://deploy-preview-5897--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski
Copy link
Collaborator

Alrighty some updates for ya:

  • We can use the generic email, and in jurisdictions will eventually override with the support email and not use the advocate's email
  • Updating to the applications page seems like a great improvement!
  • I'll check with Yazeed on which translations we should expect to see in the migration file
  • I pulled the confirmation work into a separate ticket so no need to do that here

@KrissDrawing
Copy link
Collaborator Author

Added isAdvocate for user.dto, so after updating it in prisma studio or sth it should be working as expected.
It still is mocked for public application to not mix it.

Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall but a few changes requested

@YazeedLoonat YazeedLoonat added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Feb 24, 2026
@KrissDrawing KrissDrawing added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging questions labels Feb 25, 2026
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I think this can get merged in once the snapshot indexing gets removed

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Feb 26, 2026
@KrissDrawing KrissDrawing merged commit a2b0f87 into main Feb 27, 2026
32 of 34 checks passed
@KrissDrawing KrissDrawing deleted the 5667/Housing-advocate-Application-email-changes branch February 27, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants