fix: update emails for advocate and applicant#5897
Merged
KrissDrawing merged 15 commits intomainfrom Feb 27, 2026
Merged
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-msq2 canceled.
|
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Alrighty some updates for ya:
|
Collaborator
Author
|
Added |
YazeedLoonat
requested changes
Feb 24, 2026
Collaborator
YazeedLoonat
left a comment
There was a problem hiding this comment.
looks good overall but a few changes requested
api/prisma/migrations/50_update_application_update_advocate_translations/migration.sql
Show resolved
Hide resolved
YazeedLoonat
approved these changes
Feb 25, 2026
Collaborator
YazeedLoonat
left a comment
There was a problem hiding this comment.
looks good I think this can get merged in once the snapshot indexing gets removed
ludtkemorgan
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5667
Description
Adds alternate email copy for advocate, also sends 2 emails when both email addresses provided.
Now im not sure if for applicant we should display advocate email (this unanswered comment).
Not sure if i should update link to redirect to
/account/applicationsinstead of login page 🤔Also not sure how it works with new languages, does it make sense to add them to migration, not sure if they are present in DB.
And kind of missed whole confirmation part of this task. But at this point not sure what should be changed there
How Can This Be Tested/Reviewed?
Run migration. Create application with email address and alternate contact email address. On database set
isAdvocateto true for alternate contact email user. Update application with waitlist number changes. It should send email. Check how it behaves for different languages (on local we might have justes). It should work as before for isAdvocate set to false.Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: