You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR addresses parts of related issues like #2240#2241
Addresses the issue in full
Addresses only certain aspects of the issue
Description
This targets our public application form, but in general: form fields that, when selected, show additional fields (like "I have a second phone number" or indicating you work in the county) need to have aria-controls set to the ID of the section that will be toggled on, and the ID must always be in the DOM. If it's a checkbox, it should also have aria-expanded. Voiceover is not consistent about this with testing, but JAWS relies on this more.
How Can This Be Tested/Reviewed?
Recommend reviewing with the hide whitespace toggle on - these announcements are not getting read in Voiceover which I believe is expected, but this is best practice afaik!
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 review neededRequires 1 more review before ready to mergea11yAn accessibility bug
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emilyjablonski
added
a11y
This PR addresses parts of related issues like #2240 #2241
Description
This targets our public application form, but in general: form fields that, when selected, show additional fields (like "I have a second phone number" or indicating you work in the county) need to have aria-controls set to the ID of the section that will be toggled on, and the ID must always be in the DOM. If it's a checkbox, it should also have aria-expanded. Voiceover is not consistent about this with testing, but JAWS relies on this more.
How Can This Be Tested/Reviewed?
Recommend reviewing with the hide whitespace toggle on - these announcements are not getting read in Voiceover which I believe is expected, but this is best practice afaik!
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-controls#:~:text=Explore%20now-,Description,of%20the%20element%20it%20controls.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: