Skip to content

fix: aria controls toggled fields #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emilyjablonski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: aria controls toggled fields #5938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared-helpers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"prettier": "prettier --write \"**/*.ts\""
},
"dependencies": {
"@bloom-housing/ui-components": "13.0.3",
"@bloom-housing/ui-components": "13.0.6",
"@bloom-housing/ui-seeds": "3.3.1",
"@heroicons/react": "^2.1.1",
"axios-cookiejar-support": "^5.0.5",
Expand Down
2 changes: 1 addition & 1 deletion sites/partners/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"dependencies": {
"@bloom-housing/shared-helpers": "^7.7.1",
"@bloom-housing/ui-components": "13.0.3",
"@bloom-housing/ui-components": "13.0.6",
"@bloom-housing/ui-seeds": "3.3.1",
"@heroicons/react": "^2.2.0",
"@mapbox/mapbox-sdk": "^0.13.0",
Expand Down
2 changes: 1 addition & 1 deletion sites/public/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"dependencies": {
"@bloom-housing/shared-helpers": "^7.7.1",
"@bloom-housing/ui-components": "13.0.3",
"@bloom-housing/ui-components": "13.0.6",
"@bloom-housing/ui-seeds": "3.3.1",
"@heroicons/react": "^2.1.1",
"@mapbox/mapbox-sdk": "^0.13.0",
Expand Down
415 changes: 216 additions & 199 deletions sites/public/src/pages/applications/contact/address.tsx
View file
Open in desktop

Large diffs are not rendered by default.

42 changes: 23 additions & 19 deletions sites/public/src/pages/applications/contact/alternate-contact-type.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,28 +116,32 @@ const ApplicationAlternateContactType = () => {
inputProps={{
value: option,
defaultChecked: application.alternateContact.type === option,
"aria-controls": option === "other" ? "other-type" : undefined,
}}
dataTestId={"app-alternate-type"}
/>

{option === "other" && type === "other" && (
<Field
controlClassName="mt-4"
id="otherType"
name="otherType"
label={t("application.alternateContact.type.otherTypeFormPlaceholder")}
defaultValue={application.alternateContact.otherType}
validation={{ required: true, maxLength: 64 }}
error={errors.otherType}
errorMessage={
errors.otherType?.type === "maxLength"
? t("errors.maxLength", { length: 64 })
: t("application.alternateContact.type.otherTypeValidationErrorMessage")
}
register={register}
dataTestId={"app-alternate-other-type"}
/>
)}
<div id="other-type">
{option === "other" && type === "other" && (
<Field
className="seeds-p-be-4"
id="otherType"
name="otherType"
label={t("application.alternateContact.type.otherTypeFormPlaceholder")}
defaultValue={application.alternateContact.otherType}
validation={{ required: true, maxLength: 64 }}
error={errors.otherType}
errorMessage={
errors.otherType?.type === "maxLength"
? t("errors.maxLength", { length: 64 })
: t(
"application.alternateContact.type.otherTypeValidationErrorMessage"
)
}
register={register}
dataTestId={"app-alternate-other-type"}
/>
)}
</div>
{i === altContactRelationshipKeys.length - 1 && (
<>
{errors.type && (
Expand Down
5 changes: 4 additions & 1 deletion sites/public/src/pages/applications/contact/name.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,11 @@ const ApplicationName = () => {
{t("application.name.yourDateOfBirth")}
</>
}
ariaDescribedBy="dob-helper"
/>
<p className={"field-sub-note"}>{t("application.name.dobHelper")}</p>
<p id="dob-helper" className={"field-sub-note"}>
{t("application.name.dobHelper")}
</p>
</CardSection>
<CardSection divider={"flush"} className={"border-none"}>
<legend
Expand Down
Loading
Loading