Skip to content

Parse debugger as statement#4510

Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom
zzzdong:parse-debugger-stmt
Oct 29, 2025
Merged

Parse debugger as statement#4510
jedel1043 merged 1 commit intoboa-dev:mainfrom
zzzdong:parse-debugger-stmt

Conversation

@zzzdong
Copy link
Contributor

@zzzdong zzzdong commented Oct 29, 2025

This Pull Request fixes #4482 .

It changes the following:

  • parser, parse debugger as statement instead of expression.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,595 50,595 0
Passed 47,656 47,678 +22
Ignored 2,036 2,036 0
Failed 903 881 -22
Panics 0 0 0
Conformance 94.19% 94.23% +0.04%
Fixed tests (23):
test/language/statements/debugger/expression.js (previously Failed)
test/staging/Intl402/Temporal/old/islamic-calendars-islamic-tbla.js (previously Failed)
test/staging/Intl402/Temporal/old/islamic-calendars-islamic-umalqura.js (previously Failed)
test/staging/Intl402/Temporal/old/addition-across-lunisolar-leap-months-hebrew.js (previously Failed)
test/staging/Intl402/Temporal/old/persian-calendar.js (previously Failed)
test/staging/Intl402/Temporal/old/islamic-calendars-islamic-civil.js (previously Failed)
test/staging/Intl402/Temporal/old/hebrew-leap-months.js (previously Failed)
test/staging/Intl402/Temporal/old/addition-across-lunisolar-leap-months-chinese.js (previously Failed)
test/staging/sm/Temporal/PlainDate/from-constrain-japanese.js (previously Failed)
test/staging/sm/Temporal/PlainDate/from-constrain-hebrew.js (previously Failed)
test/staging/sm/Temporal/PlainMonthDay/from-chinese-leap-month-uncommon.js (previously Failed)
test/staging/sm/Temporal/PlainMonthDay/from-coptic.js (previously Failed)
test/staging/sm/Temporal/PlainMonthDay/from-chinese.js (previously Failed)
test/staging/sm/Temporal/PlainMonthDay/from-chinese-leap-month-common.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/from/remapping-era.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/prototype/subtract/options-undefined.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/prototype/with/minimum-valid-year-month.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/prototype/add/options-undefined.js (previously Failed)
test/intl402/Temporal/PlainDate/from/remapping-era.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/until/until-across-lunisolar-leap-months.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/with/gregorian-mutually-exclusive-fields.js (previously Failed)
test/intl402/Temporal/PlainMonthDay/from/reference-year-1972.js (previously Failed)
test/intl402/Temporal/PlainMonthDay/from/constrain-to-leap-day.js (previously Failed)
Broken tests (1):
test/staging/sm/Temporal/PlainDate/from-islamic-umalqura.js (previously Passed)

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.22%. Comparing base (6ddc2b4) to head (72550fb).
⚠️ Report is 578 commits behind head on main.

Files with missing lines Patch % Lines
core/ast/src/operations/mod.rs 0.00% 3 Missing ⚠️
core/ast/src/statement/mod.rs 0.00% 3 Missing ⚠️
core/parser/src/parser/statement/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4510      +/-   ##
==========================================
+ Coverage   47.24%   57.22%   +9.98%     
==========================================
  Files         476      503      +27     
  Lines       46892    57416   +10524     
==========================================
+ Hits        22154    32859   +10705     
+ Misses      24738    24557     -181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks great!

@jedel1043 jedel1043 added this pull request to the merge queue Oct 29, 2025
Merged via the queue into boa-dev:main with commit 868d13f Oct 29, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

debugger is a statement, not an expression

2 participants