Skip to content

test: add Number.toPrecision and operator edge case tests#4997

Merged
jedel1043 merged 4 commits intoboa-dev:mainfrom
shruti2522:number-tests
Mar 12, 2026
Merged

test: add Number.toPrecision and operator edge case tests#4997
jedel1043 merged 4 commits intoboa-dev:mainfrom
shruti2522:number-tests

Conversation

@shruti2522
Copy link
Contributor

It changes the following:

  • fixed typo in LinearSpan doc comment (LinearPosition -> LinearSpan)
  • Added toPrecision edge case tests for NaN, Infinity, -0, and carry over rounding
  • Added tests for NaN comparisons, BigInt mixed type throwing behaviors, BigInt unsigned right shift (>>>) throws and instanceof with custom [Symbol.hasInstance]

@shruti2522 shruti2522 requested a review from a team as a code owner March 11, 2026 12:33
@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,902 49,901 -1
Ignored 2,222 2,222 0
Failed 839 840 +1
Panics 0 0 0
Conformance 94.22% 94.22% -0.00%
Broken tests (1):
test/built-ins/Object/freeze/typedarray-backed-by-resizable-buffer.js (previously Passed)

Tested main commit: 8225dc5409d9b41eb4b8045c657122c9c28a503b
Tested PR commit: 6fc3b3ba0ee212b0b26ffdc7cb83451fe3185e42
Compare commits: 8225dc5...6fc3b3b

@jedel1043 jedel1043 added the C-Tests Issues and PRs related to the tests. label Mar 12, 2026
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jedel1043 jedel1043 enabled auto-merge March 12, 2026 15:04
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.59%. Comparing base (6ddc2b4) to head (6fc3b3b).
⚠️ Report is 814 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4997       +/-   ##
===========================================
+ Coverage   47.24%   58.59%   +11.35%     
===========================================
  Files         476      559       +83     
  Lines       46892    61459    +14567     
===========================================
+ Hits        22154    36014    +13860     
- Misses      24738    25445      +707     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 added the Waiting On Author Waiting on PR changes from the author label Mar 12, 2026
auto-merge was automatically disabled March 12, 2026 22:07

Head branch was pushed to by a user without write access

@jedel1043 jedel1043 enabled auto-merge March 12, 2026 22:32
@jedel1043 jedel1043 added this pull request to the merge queue Mar 12, 2026
Merged via the queue into boa-dev:main with commit 15a6b94 Mar 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Tests Issues and PRs related to the tests. Waiting On Author Waiting on PR changes from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants