Skip to content

test: add Number.toPrecision and operator edge case tests #4997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedel1043 merged 4 commits into from
Mar 12, 2026
Merged

test: add Number.toPrecision and operator edge case tests #4997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da2585f
test: add Number.toPrecision and operator edge case tests
shruti2522 Mar 11, 2026
c0022a2
Merge branch 'main' into number-tests
shruti2522 Mar 11, 2026
ab15d22
Merge branch 'main' into number-tests
shruti2522 Mar 12, 2026
6fc3b3b
test: add Number.toPrecision and operator edge case tests
shruti2522 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/ast/src/position.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ pub struct LinearSpan {
end: LinearPosition,
}
impl LinearSpan {
/// Creates a new `LinearPosition`.
/// Creates a new `LinearSpan`.
///
/// # Panics
///
Expand Down
26 changes: 26 additions & 0 deletions core/engine/src/builtins/number/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,3 +642,29 @@ fn issue_2717() {
),
]);
}

#[test]
fn to_precision_edge_cases() {
run_test_actions([
TestAction::assert_eq("(NaN).toPrecision(3)", js_str!("NaN")),
TestAction::assert_eq("(Infinity).toPrecision(3)", js_str!("Infinity")),
TestAction::assert_eq("(-Infinity).toPrecision(3)", js_str!("-Infinity")),
TestAction::assert_eq("(-0).toPrecision(5)", js_str!("0.0000")),
// Carry-over rounding tests
TestAction::assert_eq("(9.95).toPrecision(2)", js_str!("9.9")),
TestAction::assert_eq("(99.95).toPrecision(3)", js_str!("100")),
TestAction::assert_eq("(999.95).toPrecision(4)", js_str!("1000")),
TestAction::assert_eq("(9.5).toPrecision(1)", js_str!("1e+1")),
TestAction::assert_eq("(123.456).toPrecision(5)", js_str!("123.46")),
TestAction::assert_eq("(0.00456).toPrecision(3)", js_str!("0.00456")),
TestAction::assert_eq("(0.0000001).toPrecision(2)", js_str!("1.0e-7")),
TestAction::assert_eq("(0.000000123).toPrecision(3)", js_str!("1.23e-7")),
TestAction::assert_eq("(123456789).toPrecision(3)", js_str!("1.23e+8")),
TestAction::assert_eq("(0.1 + 0.2).toPrecision(1)", js_str!("0.3")),
TestAction::assert_eq("(123).toPrecision(3)", js_str!("123")),
TestAction::assert_eq("(123).toPrecision(4)", js_str!("123.0")),
TestAction::assert_eq("(0).toPrecision(1)", js_str!("0")),
TestAction::assert_eq("(1).toPrecision(1)", js_str!("1")),
TestAction::assert_eq("(9).toPrecision(1)", js_str!("9")),
]);
}
159 changes: 159 additions & 0 deletions core/engine/src/tests/operators.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,3 +791,162 @@ mod in_operator {
)]);
}
}

/// `NaN` comparison, both via numeric literals (fast path) and
/// via `Number` object properties (slow path through `abstract_relation`).
///
#[test]
fn nan_comparisons() {
run_test_actions([
TestAction::assert("!(NaN == NaN)"),
TestAction::assert("NaN != NaN"),
TestAction::assert("!(NaN === NaN)"),
TestAction::assert("NaN !== NaN"),
TestAction::assert("!(NaN < 1)"),
TestAction::assert("!(NaN > 1)"),
TestAction::assert("!(NaN <= 1)"),
TestAction::assert("!(NaN >= 1)"),
TestAction::assert("!(1 < NaN)"),
TestAction::assert("!(1 > NaN)"),
TestAction::assert("!(1 <= NaN)"),
TestAction::assert("!(1 >= NaN)"),
TestAction::assert("!(NaN < NaN)"),
TestAction::assert("!(NaN > NaN)"),
TestAction::assert("!(NaN <= NaN)"),
TestAction::assert("!(NaN >= NaN)"),
TestAction::assert("!(NaN < Infinity)"),
TestAction::assert("!(NaN > -Infinity)"),
TestAction::assert("!(NaN < -Infinity)"),
TestAction::assert("!(NaN > Infinity)"),
TestAction::assert("!(new Number(NaN) < 1)"),
TestAction::assert("!(new Number(NaN) > 1)"),
TestAction::assert("!(new Number(NaN) <= 1)"),
TestAction::assert("!(new Number(NaN) >= 1)"),
TestAction::assert("!(1 < new Number(NaN))"),
TestAction::assert("!(1 > new Number(NaN))"),
TestAction::assert("!(1 <= new Number(NaN))"),
TestAction::assert("!(1 >= new Number(NaN))"),
TestAction::assert("Number.isNaN(NaN)"),
TestAction::assert("Number.isNaN(0/0)"),
TestAction::assert("!Number.isNaN(undefined)"),
TestAction::assert("!Number.isNaN('NaN')"),
]);
}

#[test]
fn bigint_mixed_type_operations() {
const MIXED_MSG: &str = "cannot mix BigInt and other types, use explicit conversions";
run_test_actions([
TestAction::assert_native_error("1n + 1", JsNativeErrorKind::Type, MIXED_MSG),
TestAction::assert_native_error("1n - 1", JsNativeErrorKind::Type, MIXED_MSG),
TestAction::assert_native_error("1n * 2", JsNativeErrorKind::Type, MIXED_MSG),
TestAction::assert_native_error("4n / 2", JsNativeErrorKind::Type, MIXED_MSG),
TestAction::assert_native_error("5n % 2", JsNativeErrorKind::Type, MIXED_MSG),
TestAction::assert_native_error("2n ** 3", JsNativeErrorKind::Type, MIXED_MSG),
TestAction::assert_native_error("1 + 1n", JsNativeErrorKind::Type, MIXED_MSG),
TestAction::assert_eq("'hello' + 1n", js_str!("hello1")),
TestAction::assert_eq("1n + 'hello'", js_str!("1hello")),
TestAction::assert_native_error(
indoc! {r#"
let numObj = { valueOf() { return 42; }, toString() { return "42"; } };
1n + numObj
"#},
JsNativeErrorKind::Type,
MIXED_MSG,
),
TestAction::assert("1n < 2"),
TestAction::assert("!(1n > 2)"),
TestAction::assert("1n <= 1"),
TestAction::assert("2n >= 2"),
TestAction::assert("(2n + 3n) === 5n"),
TestAction::assert("(10n - 4n) === 6n"),
TestAction::assert("(3n * 4n) === 12n"),
TestAction::assert("(10n / 3n) === 3n"),
TestAction::assert("(10n % 3n) === 1n"),
TestAction::assert("(2n ** 10n) === 1024n"),
]);
}

#[test]
fn ushr_bigint_type_error() {
run_test_actions([
TestAction::assert_native_error(
"1n >>> 0n",
JsNativeErrorKind::Type,
"BigInts have no unsigned right shift, use >> instead",
),
TestAction::assert_native_error(
"255n >>> 4n",
JsNativeErrorKind::Type,
"BigInts have no unsigned right shift, use >> instead",
),
TestAction::assert("(8n >> 2n) === 2n"),
TestAction::assert("(-1n >> 63n) === -1n"),
TestAction::assert("(1n << 4n) === 16n"),
]);
}

#[test]
fn instanceof_custom_has_instance() {
run_test_actions([
TestAction::assert(indoc! {r#"
class AlwaysTrue {
static [Symbol.hasInstance](_instance) {
return true;
}
}
({} instanceof AlwaysTrue)
"#}),
TestAction::assert(indoc! {r#"
class AlwaysFalse {
static [Symbol.hasInstance](_instance) {
return false;
}
}
let obj = new AlwaysFalse();
!(obj instanceof AlwaysFalse)
"#}),
TestAction::assert(indoc! {r#"
const EvenNumber = {
[Symbol.hasInstance](value) {
return typeof value === 'number' && value % 2 === 0;
}
};
(2 instanceof EvenNumber) && !(3 instanceof EvenNumber)
"#}),
TestAction::assert_native_error(
indoc! {r#"
class Throws {
static [Symbol.hasInstance](_instance) {
throw new TypeError("hasInstance threw");
}
}
({} instanceof Throws)
"#},
JsNativeErrorKind::Type,
"hasInstance threw",
),
TestAction::assert_native_error(
"let s = new String(); s instanceof {}",
JsNativeErrorKind::Type,
"right-hand side of 'instanceof' is not callable",
),
TestAction::assert_native_error(
"42 instanceof 'not-a-constructor'",
JsNativeErrorKind::Type,
"right-hand side of 'instanceof' should be an object, got `string`",
),
TestAction::assert(indoc! {r#"
const Truthy = {
[Symbol.hasInstance]() { return 1; }
};
({} instanceof Truthy)
"#}),
TestAction::assert(indoc! {r#"
const Falsy = {
[Symbol.hasInstance]() { return 0; }
};
!({} instanceof Falsy)
"#}),
]);
}
Loading