Skip to content

refactor(engine): encapsulate Context VM field access behind wrapper methods #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hansl wants to merge 1 commit into
base: main
Choose a base branch
from
+856 −618

refactor(engine): encapsulate Context VM field access behind wrapper …

498b424
Select commit
Loading
Failed to load commit list.
Open

refactor(engine): encapsulate Context VM field access behind wrapper methods #5149

refactor(engine): encapsulate Context VM field access behind wrapper …
498b424
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 19, 2026 in 1s

59.61% (+12.36%) compared to 6ddc2b4

View this Pull Request on Codecov

59.61% (+12.36%) compared to 6ddc2b4

Details

Codecov Report

❌ Patch coverage is 76.82737% with 149 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.61%. Comparing base (6ddc2b4) to head (498b424).
⚠️ Report is 894 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/object/builtins/jspromise.rs 0.00% 16 Missing ⚠️
core/engine/src/builtins/proxy/mod.rs 0.00% 11 Missing ⚠️
core/engine/src/vm/opcode/call/mod.rs 47.36% 10 Missing ⚠️
core/engine/src/vm/opcode/iteration/iterator.rs 61.53% 10 Missing ⚠️
core/engine/src/vm/opcode/environment/mod.rs 67.85% 9 Missing ⚠️
core/engine/src/vm/opcode/define/class/setter.rs 20.00% 8 Missing ⚠️
core/engine/src/vm/opcode/set/private.rs 20.00% 8 Missing ⚠️
core/engine/src/vm/opcode/set/property.rs 66.66% 8 Missing ⚠️
core/engine/src/vm/opcode/control_flow/jump.rs 76.66% 7 Missing ⚠️
core/engine/src/vm/opcode/push/class/private.rs 0.00% 7 Missing ⚠️
... and 23 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5149       +/-   ##
===========================================
+ Coverage   47.24%   59.61%   +12.36%     
===========================================
  Files         476      581      +105     
  Lines       46892    63218    +16326     
===========================================
+ Hits        22154    37685    +15531     
- Misses      24738    25533      +795

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov