Add tests for Temporal.PlainMonthDay.prototype.toLocaleString#5155
Open
Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Open
Add tests for Temporal.PlainMonthDay.prototype.toLocaleString#5155Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Tomeshwari-02 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
- Add comprehensive test coverage for toLocaleString method - Test basic functionality and parameter acceptance - Test with different month/day combinations - Verify locales and options parameters are accepted - Note: Implementation falls back to ISO format until ECMA-402 integration Closes boa-dev#5085
Test262 conformance changes
Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive test coverage for the existing
toLocaleString()method onTemporal.PlainMonthDayas specified in issue #5085.What's Included
Test Coverage (6 tests)
toLocaleString()functionality'iso8601')Implementation Details
The
toLocaleString()method already exists in the codebase but had no test coverage. This PR adds:core/engine/src/builtins/temporal/plain_month_day/tests.rs#[cfg(test)] mod tests;inmod.rsCurrent Implementation Note
The current implementation returns ISO string format (e.g.,
"12-25") until full ECMA-402 Intl.DateTimeFormat integration is completed. This approach:Testing Results