Skip to content

Add tests for Temporal.PlainMonthDay.prototype.toLocaleString #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tomeshwari-02 wants to merge 1 commit into from
Closed

Add tests for Temporal.PlainMonthDay.prototype.toLocaleString #5155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/engine/src/builtins/temporal/plain_month_day/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,3 +627,6 @@ fn to_temporal_month_day(
// 16. Return ! CreateTemporalMonthDay(isoDate, calendar).
Ok(InnerMonthDay::from_parsed(parse_record)?)
}

#[cfg(test)]
mod tests;
86 changes: 86 additions & 0 deletions core/engine/src/builtins/temporal/plain_month_day/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
use crate::{TestAction, run_test_actions};

#[test]
fn pmd_basic_construction() {
run_test_actions([
TestAction::run(
"let pmd = new Temporal.PlainMonthDay(12, 25)",
),
TestAction::assert("pmd.monthCode === 'M12'"),
TestAction::assert("pmd.day === 25"),
]);
}

#[test]
fn pmd_to_locale_string_basic() {
run_test_actions([
TestAction::run(
"let pmd = new Temporal.PlainMonthDay(12, 25)",
),
// toLocaleString should return a string
TestAction::assert("typeof pmd.toLocaleString() === 'string'"),
// Should contain month and day components
TestAction::assert("pmd.toLocaleString().includes('12')"),
TestAction::assert("pmd.toLocaleString().includes('25')"),
]);
}

#[test]
fn pmd_to_locale_string_with_calendar() {
run_test_actions([
TestAction::run(
"let pmd = new Temporal.PlainMonthDay(12, 25, 'iso8601')",
),
// Should accept calendar parameter
TestAction::assert("typeof pmd.toLocaleString() === 'string'"),
// Should contain month and day information
TestAction::assert("pmd.toLocaleString().includes('12')"),
TestAction::assert("pmd.toLocaleString().includes('25')"),
]);
}

#[test]
fn pmd_to_locale_string_with_locales() {
run_test_actions([
TestAction::run(
"let pmd = new Temporal.PlainMonthDay(12, 25)",
),
// Should accept locales parameter (even if not fully implemented yet)
TestAction::assert("typeof pmd.toLocaleString('en-US') === 'string'"),
TestAction::assert("typeof pmd.toLocaleString(['en-US', 'fr-FR']) === 'string'"),
]);
}

#[test]
fn pmd_to_locale_string_with_options() {
run_test_actions([
TestAction::run(
"let pmd = new Temporal.PlainMonthDay(12, 25)",
),
// Should accept options parameter (even if not fully implemented yet)
TestAction::assert("typeof pmd.toLocaleString(undefined, {}) === 'string'"),
]);
}

#[test]
fn pmd_to_locale_string_different_dates() {
run_test_actions([
TestAction::run(
"let pmd1 = new Temporal.PlainMonthDay(1, 1)",
),
TestAction::run(
"let pmd2 = new Temporal.PlainMonthDay(7, 4)",
),
TestAction::run(
"let pmd3 = new Temporal.PlainMonthDay(10, 31)",
),
// All should return strings
TestAction::assert("typeof pmd1.toLocaleString() === 'string'"),
TestAction::assert("typeof pmd2.toLocaleString() === 'string'"),
TestAction::assert("typeof pmd3.toLocaleString() === 'string'"),
// Should contain correct values
TestAction::assert("pmd1.toLocaleString().includes('01')"),
TestAction::assert("pmd2.toLocaleString().includes('07')"),
TestAction::assert("pmd3.toLocaleString().includes('10')"),
]);
}
Loading