Skip to content

Conversation

@43081j
Copy link
Collaborator

@43081j 43081j commented Jun 22, 2025

Various prompts output trailing space in some situations.

This removes all such space and fixes a couple of bugs that were discovered while doing so.

Bugs which were fixed:

  • Autocomplete had an empty line between the title and the rest. Now this is a bar
  • Multi-select validation errors were not aligned after the first line
  • Autocomplete isNavigating was not reset when pressing a non-navigation key in non-multiple mode

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2025

🦋 Changeset detected

Latest commit: 0a5119f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clack/prompts Patch
@clack/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@43081j 43081j requested a review from dreyfus92 June 22, 2025 23:18
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 22, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@351
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@351

commit: 0a5119f

Various prompts output trailing space in some situations.

This removes all such space and fixes a couple of bugs that were
discovered while doing so.

Bugs which were fixed:

- Autocomplete had an empty line between the title and the rest. Now
  this is a bar
- Multi-select validation errors were not aligned after the first line
- Autocomplete `isNavigating` was not reset when pressing a
  non-navigation key in non-multiple mode
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@dreyfus92
Copy link
Member

Just fix the tests 😁

@43081j 43081j merged commit 7df841d into main Jun 23, 2025
7 checks passed
@43081j 43081j deleted the trimless branch June 23, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants