-
Notifications
You must be signed in to change notification settings - Fork 140
Adopt Swatinem/rust-cache for faster CI #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
4f20f21
to
7b610f4
Compare
I've noticed that compiling Rust takes a lot of time in CI. Hopefully this will help 🤞 |
- name: Bootc Ubuntu Setup | ||
uses: ./.github/actions/bootc-ubuntu-setup | ||
- name: Setup Rust cache | ||
uses: Swatinem/rust-cache@v2 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work :(
Error: Subscription is not valid. Reach out to [email protected]
https://github.com/bootc-dev/bootc/actions/runs/18330132425/job/52203562664?pr=1676#step:4:15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I guess they release some actions to the public and not others. I couldn't see any docs that suggested it was paywalled.
b0ac038
to
6e01f8c
Compare
Signed-off-by: Ondra Pelech <[email protected]>
6e01f8c
to
c4bdbdc
Compare
Hi, thanks for submitting this! In general actually I'm trying to move most things into a container build, and there's some more nontrivial work to enable using this action with that. We're relying today on intermediate cache layers in the container build. Now docker does have support for caching layers to/from GHA but podman doesn't directly. It might not be had to add though. My inclination on compliation speedup here was to look at https://github.com/mozilla/sccache/ |
No description provided.