Adopt Swatinem/rust-cache for faster CI #1676
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,12 @@ jobs: | |
| - uses: actions/checkout@v4 | ||
| - name: Bootc Ubuntu Setup | ||
| uses: ./.github/actions/bootc-ubuntu-setup | ||
| - name: Setup Rust cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| cache-all-crates: true | ||
| save-if: ${{ github.ref == 'refs/heads/main' }} | ||
| lookup-only: ${{ github.ref == 'refs/heads/main' }} | ||
|
There was a problem hiding this comment. Why are you setting There was a problem hiding this comment. This will ensure that on There was a problem hiding this comment.
Yes, that's the effect the change has. I'm asking about why we want that effect - it's not the default, so you went to some effort to turn it on. A github-wide search shows it's definitely used elsewhere but...why? |
||
| - name: Validate (default) | ||
| run: just validate | ||
| # Build container with continuous repository enabled | ||
|
|
@@ -41,6 +47,12 @@ jobs: | |
| - uses: actions/checkout@v4 | ||
| - name: Bootc Ubuntu Setup | ||
| uses: ./.github/actions/bootc-ubuntu-setup | ||
| - name: Setup Rust cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| cache-all-crates: true | ||
| save-if: ${{ github.ref == 'refs/heads/main' }} | ||
| lookup-only: ${{ github.ref == 'refs/heads/main' }} | ||
| - name: Build with continuous repo enabled | ||
| run: sudo just build --build-arg=continuous_repo=1 | ||
| # Check for security vulnerabilities and license compliance | ||
|
|
@@ -62,6 +74,12 @@ jobs: | |
| uses: actions/checkout@v4 | ||
| - name: Bootc Ubuntu Setup | ||
| uses: ./.github/actions/bootc-ubuntu-setup | ||
| - name: Setup Rust cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| cache-all-crates: true | ||
| save-if: ${{ github.ref == 'refs/heads/main' }} | ||
| lookup-only: ${{ github.ref == 'refs/heads/main' }} | ||
| - name: Enable fsverity for / | ||
| run: sudo tune2fs -O verity $(findmnt -vno SOURCE /) | ||
| - name: Install utils | ||
|
|
@@ -76,7 +94,6 @@ jobs: | |
| sudo podman build -t localhost/bootc-fsverity -f ci/Containerfile.install-fsverity | ||
|
|
||
| # TODO move into a container, and then have this tool run other containers | ||
| cargo build --release -p tests-integration | ||
|
|
||
| df -h / | ||
|
|
@@ -116,6 +133,12 @@ jobs: | |
| - uses: actions/checkout@v4 | ||
| - name: Bootc Ubuntu Setup | ||
| uses: ./.github/actions/bootc-ubuntu-setup | ||
| - name: Setup Rust cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| cache-all-crates: true | ||
| save-if: ${{ github.ref == 'refs/heads/main' }} | ||
| lookup-only: ${{ github.ref == 'refs/heads/main' }} | ||
| - name: Build mdbook | ||
| run: just build-mdbook | ||
| # Build containers and disk images for integration testing across OS matrix | ||
|
|
@@ -131,6 +154,12 @@ jobs: | |
| - uses: actions/checkout@v4 | ||
| - name: Bootc Ubuntu Setup | ||
| uses: ./.github/actions/bootc-ubuntu-setup | ||
| - name: Setup Rust cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| cache-all-crates: true | ||
| save-if: ${{ github.ref == 'refs/heads/main' }} | ||
| lookup-only: ${{ github.ref == 'refs/heads/main' }} | ||
| - name: Install qemu-utils | ||
| run: sudo apt install -y qemu-utils | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? My understanding is that due to how github handles caching we're safe against e.g. malicious PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will ensure that caches are saved only on
main, not on any other PRs. I think that's enough caching. It may also have some vague security benefits.But if you don't like it, it doesn't have to be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think anything that's not the default should have a comment with a rationale. When you say "enough caching" - is that to ensure that we're not evicting caches from git main with pull requests?