Change test case to match error via types, not strings #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
reviewed
Jan 17, 2025
mvo5
approved these changes
Jan 17, 2025
Minor followup to the previous change; part of the idea of having the error types here is so we can *also* dig through the `SkopeoSpawnError` and precisely match against the `std::io::ErrorKind::NotFound`, and not rely on its stringified form. This is what we'd expect other callers to do. This also avoids a double-match. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
minor-followup
branch
from
f0b2eba to
602dcba
Compare
cgwalters
commented
Jan 17, 2025
| ); | ||
| match ImageProxy::new_with_config(config).await { | ||
| Ok(_) => panic!("Expected an error"), | ||
| Err(ref e @ Error::SkopeoSpawnError(ref inner)) => { |
There was a problem hiding this comment.
Interesting note: I needed to start using ref as we want to be able to look at both the inner and outer parts. This is pretty unusual IME.
allisonkarlitskaya
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor followup to the previous change; part of the idea of having the error types here is so we can also dig through the
SkopeoSpawnErrorand precisely match against thestd::io::ErrorKind::NotFound, and not rely on its stringified form. This is what we'd expect other callers to do.This also avoids a double-match.