-
Notifications
You must be signed in to change notification settings - Fork 1
README.md: Update for organization move #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Since the repo was imported here, thanks Tulip! Signed-off-by: Colin Walters <[email protected]>
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the Homebrew installation instructions in the README.md file to reflect the new repository location after the project's move to the bootc-dev organization. The changes involve modifying the brew install commands to use the updated repository path. No style guides were provided, so no style guide adherence was checked.
| ## How do I get these | ||
|
|
||
| ```bash | ||
| brew install tulilirockz/bcvk/bcvk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository location has changed, so the install command should be updated to reflect this change. This ensures users install from the correct source.
It looks like the previous location was tulilirockz/bcvk/bcvk and it's now bootc-dev/bcvk/bcvk.
| brew install tulilirockz/bcvk/bcvk | |
| brew install bootc-dev/bcvk/bcvk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read this three times and it sure looks like Gemini is just...saying I need to do what I did?
| You can also download the latest dev version by running this instead: | ||
|
|
||
| ```bash | ||
| brew install --head tulilirockz/bcvk/bcvk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous change, the --head install command should also be updated to reflect the new repository location. This ensures users installing the development version use the correct source.
It looks like the previous location was tulilirockz/bcvk/bcvk and it's now bootc-dev/bcvk/bcvk.
| brew install --head tulilirockz/bcvk/bcvk | |
| brew install --head bootc-dev/bcvk/bcvk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
|
Do you want to continue to be a maintainer/reviewer here? |
|
I'd be fine with it, I'm not 1000% familiar with homebrew but this is meant to be highly automated anyways |
Since the repo was imported here, thanks Tulip!