Skip to content

fix: add --cov flags to Windows CI pytest command, fixes #9418 #9419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mr-raj12 wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix: add --cov flags to Windows CI pytest command, fixes #9418 #9419

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6439b73
fix: add --cov flags to Windows CI pytest command, fixes #9418
mr-raj12 Feb 28, 2026
d4fb70d
fix: add explicit coverage XML report and fix codecov upload for Wind…
mr-raj12 Feb 28, 2026
cc0ed81
fix: remove extra coverage config, match Linux CI style
mr-raj12 Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ jobs:
export PATH="$GITHUB_WORKSPACE/dist/binary/borg-dir:$PATH"
borg.exe -V
. env/bin/activate
python -m pytest -n4 --benchmark-skip -vv -rs -k "not remote" --junitxml=test-results.xml
python -m pytest -n4 --benchmark-skip -vv -rs -k "not remote" --cov=borg --cov-config=pyproject.toml --junitxml=test-results.xml
Copy link
Member

@ThomasWaldmann ThomasWaldmann Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

but why does it say the test coverage of the project did change by 0%? shouldn't we see an increase due to this change?

Copy link
Member

@ThomasWaldmann ThomasWaldmann Feb 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.codecov.io/gh/borgbackup/borg/pull/9419/blob/src/borg/platform/__init__.py?dropdown=coverage

does not show coverage for win32. also not for some others.

Copy link
Contributor Author

@mr-raj12 mr-raj12 Feb 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying few tweaks before final squash and force push

Copy link
Member

@ThomasWaldmann ThomasWaldmann Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks better for win32.

Copy link
Member

@ThomasWaldmann ThomasWaldmann Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, latest run does not have windows coverage.

- name: Upload test results to Codecov
if: ${{ !cancelled() }}
Expand Down