More comparisons #1896
Merged
More comparisons #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-krishnan
approved these changes
Nov 19, 2024
travisdriver
approved these changes
Nov 20, 2024
Contributor
travisdriver
left a comment
travisdriver
left a comment
There was a problem hiding this comment.
Looks great, excited to try out in GTSfM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
EssentialMatrixFactor: makes error much less as only pairwise errors checkedIt's clear that the binary
EssentialMatrixFactorsdo much better in terms of geodesic distance, even without "enforcing consistency". They also optimize quite fast. Although: I have to admit I don't understand how they can do better than "Calibrated", which uses ground truth K. Maybe the transfer error pushes away from ground truth in an unexpected way.