Updates based on profiling #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Dec 2, 2024
Member
dellaert
left a comment
dellaert
left a comment
There was a problem hiding this comment.
Cool.
About question at the end: let’s be data-driven: first need to address quadratic growth, then we can assess linear growth if significant constants.
Contributor
Author
I emailed you about the quadratic growth. I've managed to isolate the problem, but the solution needs some pondering over. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gperftoolslinking.computeThresholdmethod to isolate computing the pruning threshold.prunedtoHybridGaussianConditionalto avoid pruning an already pruned conditional.Rot3::expmapin the wrapper.The
pruneflag helps in longer sequences, but is not the major bottleneck. That would beEliminateDiscrete.I am wondering if there is a way to not prune all the way down on the
HybridBayesTree? Seems like extra computation for no reason.