-
Notifications
You must be signed in to change notification settings - Fork 59
Update dependencies for PyTorch, for system cuda13 #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y README for UV installation instructions and system package requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates PyTorch, torchvision, and xformers dependencies to support NVIDIA Blackwell GPUs (RTX 5060 Ti with CUDA capability sm_120). The main driver is resolving a CUDA compatibility error where the previous PyTorch 2.5.1 with CUDA 12.1 support did not include the sm_120 architecture needed for Blackwell GPUs.
Key changes:
- Upgraded PyTorch from 2.5.1 to >=2.7.0,<2.8.0 and torchvision from 0.20.1 to >=0.22.0,<0.23.0
- Updated CUDA support from 12.1 to 12.8 for Blackwell GPU compatibility
- Upgraded xformers from 0.0.29 to 0.0.30 for compatibility with newer PyTorch
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Updated PyTorch and torchvision version constraints, added pytorch-cu128 index, updated xformers version, and changed CUDA version comment to reflect Blackwell support |
| README.md | Updated installation instructions to reflect CUDA 12.8 and torch 2.7.0, reorganized UV setup section headers, and moved system package installation instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dellaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you !!!!!
Let me try it on my machine and if it works I’ll approve and merge
dellaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, and one question:
we now seem to have two sets of requirements: one in yml file, and one in toml file? And we have to keep them in sync?
|
@dellaert All *.md file are in the root and looks unorganized. |
- Created docs/ folder with setup/ and deployment/ subdirectories - Moved conda-setup.md to docs/setup/ - Moved uv-setup.md to docs/setup/ - Moved CLUSTER.md to docs/deployment/ - Moved CONTRIBUTING.md to docs/ - Updated all references in README.md to point to new locations This improves project organization by keeping the root directory cleaner and grouping related documentation together.
dellaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
cuda 13 running issue from Prof. Frank