Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
@hidmic Thanks a lot for the PR :) Which theme did you test it with? @aniketsalve22 Could you please test it with pydata theme used in the demo, rtd-theme and book-theme? |
I'm using the |
|
Alright. @aniketsalve22 I guess it then makes sense to test the changes without any of our customisations. |
|
AMD docs look pretty too. Don't mind which path we take so long as we can get the dark mode to work. Great tool BTW. |
|
@aniketsalve22 Just realized we are using sphinx-book-theme for demo as well and not pydata-theme. |
|
I mentioned on #100 that I can with upstreaming my changes, I don't have the time right now, but I can give a brief summary of what I did for the ROCm documentation: For ROCm documentation the style is applied by a the "rocm-docs" sphinx theme hosted here: https://github.com/ROCm/rocm-docs-core. It is in turn based on sphinx-book-theme. The PR that added the styling you see was ROCm/rocm-docs-core#36. The source of Tangentially, I did not use sass even for prepocessing as I found it to be slightly wrong (It breaks rules that refer to More importantly I replaced references of The rest is just slightly different choices compared to the demo in doxysphinx, for example I chose to hide the titles from the doxygen html and instead use the sphinx ones, which I think integrates better with the rest of the site. |
Precisely what the title says. CSS scoping for
htmlelements was leaving a fair amount of rules behind, such as those forhtml.dark-modeelements. Also, some light theme appropriate coloring was tagged as!important. This patch fixes it all.