feat: add nvidia MIG Settings#63
Merged
piyush-jena merged 1 commit intobottlerocket-os:developfrom Feb 5, 2025
Merged
Conversation
a5f78d1 to
f716594
Compare
f716594 to
61baa85
Compare
61baa85 to
4a92b7e
Compare
ef6e3dc to
7b480a9
Compare
ytsssun
approved these changes
Jan 27, 2025
bcressey
reviewed
Jan 28, 2025
Contributor
bcressey
left a comment
There was a problem hiding this comment.
I haven't reviewed this in depth, just flagged a couple of style issues that would be good to fix while reviewing bottlerocket-os/bottlerocket-core-kit#258
KCSesh
reviewed
Jan 28, 2025
7b480a9 to
cb83a60
Compare
Contributor
Author
|
Fixed comments in the last force push ^ |
KCSesh
reviewed
Feb 3, 2025
KCSesh
reviewed
Feb 3, 2025
KCSesh
reviewed
Feb 3, 2025
cb83a60 to
586e5aa
Compare
Contributor
Author
|
Force push fixes above comments. |
KCSesh
approved these changes
Feb 3, 2025
cbgbt
reviewed
Feb 3, 2025
Contributor
cbgbt
left a comment
There was a problem hiding this comment.
Other than the crate versioning comment, this lgtm!
bottlerocket-settings-models/settings-extensions/kubelet-device-plugins/src/lib.rs
Show resolved
Hide resolved
586e5aa to
5c731ae
Compare
Contributor
Author
|
Force push updates the |
5c731ae to
2fae7f8
Compare
Contributor
Author
|
Missed |
KCSesh
approved these changes
Feb 3, 2025
cbgbt
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
settings.kubelet-device-plugins.nvidia.device-partitioning-strategyandsettings.kubelet-device-plugins.nvidia.mig.profilein bottlerocket.Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.