-
Notifications
You must be signed in to change notification settings - Fork 186
fix: Fix parsing content length header #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build #4458Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #4455Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #4464Details
💛 - Coveralls |
|
|
||
| @Test | ||
| public void testLargeBinaryResponseContentLength() { | ||
| long contentLength = 2352815193L; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this magic number? You want it to be larger than MAX int? Some random value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a number bigger than Max Int and which is customer having issue with, can be also considered as a random number :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why not putting there this explicitly Integer.MAX_VALUE + 100?
antusus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.