Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/box/sdk/BinaryBodyUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ private static long getContentLengthFromAPIResponse(BoxAPIResponse response) {

if (headerValue != null) {
try {
length = Integer.parseInt(headerValue);
length = Long.parseLong(headerValue);
} catch (NumberFormatException e) {
throw new RuntimeException("Invalid content length: " + headerValue);
}
Expand Down
73 changes: 73 additions & 0 deletions src/test/java/com/box/sdk/BoxAPIResponseTest.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.box.sdk;

import static com.box.sdk.BinaryBodyUtils.writeStreamWithContentLength;
import static com.box.sdk.StandardCharsets.UTF_8;
import static com.box.sdk.http.ContentType.APPLICATION_JSON;
import static java.util.Arrays.asList;
Expand All @@ -9,13 +10,71 @@
import static org.hamcrest.Matchers.is;

import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;
import org.junit.Test;

public class BoxAPIResponseTest {

/**
* Simulated large InputStream that generates data on demand.
*/
static class LargeByteArrayInputStream extends InputStream {
private final long size;
private long bytesRead = 0;

LargeByteArrayInputStream(long size) {
this.size = size;
}

@Override
public int read() throws IOException {
if (bytesRead < size) {
bytesRead++;
return 'A'; // Simulated byte
}
return -1; // End of stream
}

@Override
public int read(byte[] b, int off, int len) throws IOException {
if (bytesRead >= size) {
return -1;
}
int bytesToRead = (int) Math.min(len, size - bytesRead);
for (int i = 0; i < bytesToRead; i++) {
b[off + i] = 'A';
}
bytesRead += bytesToRead;
return bytesToRead;
}
}


/**
* Null OutputStream that discards written data (useful for counting bytes).
*/
class NullOutputStream extends OutputStream {
long bytesWritten = 0;
@Override
public void write(int b) {
bytesWritten++;
}

@Override
public void write(byte[] b, int off, int len) {
bytesWritten += len;
}

long getBytesWritten() {
return bytesWritten;
}
}

@Test
public void testAPIResponseHeaderIsCaseInsensitive() {
Map<String, List<String>> headers = new TreeMap<>();
Expand Down Expand Up @@ -85,4 +144,18 @@ public void testJsonResponseToString() {
+ "Body:\n{\"foo\":\"bar\"}")
);
}

@Test
public void testLargeBinaryResponseContentLength() {
long contentLength = 2352815193L;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this magic number? You want it to be larger than MAX int? Some random value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a number bigger than Max Int and which is customer having issue with, can be also considered as a random number :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why not putting there this explicitly Integer.MAX_VALUE + 100?

Map<String, List<String>> headers = new TreeMap<>();
headers.put("content-length", singletonList(Long.toString(contentLength)));
LargeByteArrayInputStream inputStream = new LargeByteArrayInputStream(contentLength);
NullOutputStream outputStream = new NullOutputStream();
BoxAPIResponse response = new BoxAPIResponse(
202, "GET", "https://aaa.com", headers, inputStream, "image/jpg", -1
);
writeStreamWithContentLength(response, outputStream);
assertThat(outputStream.getBytesWritten(), is(contentLength));
}
}
Loading