Skip to content

fix: use Locale.ROOT to prevent issues with non-US locales#1306

Merged
mwwoda merged 3 commits intomainfrom
fix-locale-issues
Apr 29, 2025
Merged

fix: use Locale.ROOT to prevent issues with non-US locales#1306
mwwoda merged 3 commits intomainfrom
fix-locale-issues

Conversation

@mwwoda
Copy link
Contributor

@mwwoda mwwoda commented Apr 28, 2025

Fixes #1305

@coveralls
Copy link

Pull Request Test Coverage Report for Build #4568

Details

  • 14 of 23 (60.87%) changed or added relevant lines in 16 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 72.058%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxAIItem.java 0 1 0.0%
src/main/java/com/box/sdk/BoxFolder.java 1 2 50.0%
src/main/java/com/box/sdk/BoxGroupMembership.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUploadEmail.java 0 1 0.0%
src/main/java/com/box/sdk/BoxZipDownloadStatus.java 0 1 0.0%
src/main/java/com/box/sdk/internal/utils/JsonUtils.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUser.java 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #4564: -0.002%
Covered Lines: 8216
Relevant Lines: 11402

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 28, 2025

Pull Request Test Coverage Report for Build #4579

Details

  • 14 of 23 (60.87%) changed or added relevant lines in 16 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 72.058%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxAIItem.java 0 1 0.0%
src/main/java/com/box/sdk/BoxFolder.java 1 2 50.0%
src/main/java/com/box/sdk/BoxGroupMembership.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUploadEmail.java 0 1 0.0%
src/main/java/com/box/sdk/BoxZipDownloadStatus.java 0 1 0.0%
src/main/java/com/box/sdk/internal/utils/JsonUtils.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUser.java 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #4564: -0.002%
Covered Lines: 8216
Relevant Lines: 11402

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build #4570

Details

  • 14 of 23 (60.87%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 72.062%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxAIItem.java 0 1 0.0%
src/main/java/com/box/sdk/BoxFolder.java 1 2 50.0%
src/main/java/com/box/sdk/BoxGroupMembership.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUploadEmail.java 0 1 0.0%
src/main/java/com/box/sdk/BoxZipDownloadStatus.java 0 1 0.0%
src/main/java/com/box/sdk/internal/utils/JsonUtils.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUser.java 1 4 25.0%
Totals Coverage Status
Change from base Build #4564: 0.002%
Covered Lines: 8223
Relevant Lines: 11411

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build #4569

Details

  • 14 of 23 (60.87%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 72.062%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxAIItem.java 0 1 0.0%
src/main/java/com/box/sdk/BoxFolder.java 1 2 50.0%
src/main/java/com/box/sdk/BoxGroupMembership.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUploadEmail.java 0 1 0.0%
src/main/java/com/box/sdk/BoxZipDownloadStatus.java 0 1 0.0%
src/main/java/com/box/sdk/internal/utils/JsonUtils.java 0 1 0.0%
src/main/java/com/box/sdk/BoxUser.java 1 4 25.0%
Totals Coverage Status
Change from base Build #4564: 0.002%
Covered Lines: 8223
Relevant Lines: 11411

💛 - Coveralls

Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mwwoda mwwoda merged commit f083092 into main Apr 29, 2025
17 of 20 checks passed
@mwwoda mwwoda deleted the fix-locale-issues branch April 29, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BoxDeserializationException for Turkish language

3 participants