feat: add field attachment_size_limit to dpp::interaction#1478
Merged
braindigitalis merged 5 commits intobrainboxdotcc:devfrom Sep 11, 2025
Merged
feat: add field attachment_size_limit to dpp::interaction#1478braindigitalis merged 5 commits intobrainboxdotcc:devfrom
braindigitalis merged 5 commits intobrainboxdotcc:devfrom
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Mishura4
approved these changes
Sep 4, 2025
Member
|
Looks good to me, thanks for the contribution! |
Contributor
Author
|
oops, seems ive introduced an initialisation ordering warning, should i fix it? |
Member
|
For sure |
Member
|
Thanks for checking 👀 I'm now wondering why we don't have it set as error |
Contributor
Author
|
Alright! Well im glad at least i found something... also rip the macos build at least that error isn't me |
braindigitalis
requested changes
Sep 5, 2025
Contributor
braindigitalis
left a comment
There was a problem hiding this comment.
only thing to change is the defines
Contributor
Author
|
I'm unsure about size_t here, although as it is only ever compared against another size_t (and is a constant) i used it |
braindigitalis
approved these changes
Sep 8, 2025
Contributor
braindigitalis
left a comment
There was a problem hiding this comment.
these look fine to me now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the field attachment_size_limit to dpp::interaction, allowing all interactions to have the current response attachment size limit in bytes
Code change checklist