Skip to content

feat: add field attachment_size_limit to dpp::interaction #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braindigitalis merged 5 commits into from
Sep 11, 2025
Merged

feat: add field attachment_size_limit to dpp::interaction #1478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac31778
feat: add attachment_size_limit to dpp::interaction
usyless Sep 4, 2025
46ec8ca
fix: initialisation ordering warning with attachment_size_limit
usyless Sep 4, 2025
03b364e
Define constants within appcommand.h as inline constexpr
usyless Sep 5, 2025
ed8e006
Merge branch 'dev' into add-attachment-size-limit
Mishura4 Sep 5, 2025
efda227
Merge branch 'dev' into add-attachment-size-limit
usyless Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions include/dpp/appcommand.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,13 @@ namespace dpp {
* This value represents that maximum. interaction_response::add_autocomplete_choice does not allow
* adding more than this number of elements to the vector.
*/
#ifndef AUTOCOMPLETE_MAX_CHOICES
#define AUTOCOMPLETE_MAX_CHOICES 25
#endif
inline constexpr size_t AUTOCOMPLETE_MAX_CHOICES = 25;

/**
* @brief Discords default attachment size limit is 10MiB, and will be used in case
* an interaction does not contain its attachment size limit.
*/
inline constexpr uint32_t DEFAULT_ATTACHMENT_SIZE_LIMIT = 10 * 1024 * 1024;

/**
* @brief Represents command option types.
Expand Down Expand Up @@ -1093,6 +1097,11 @@ class DPP_EXPORT interaction : public managed, public json_interface<interaction
*/
std::string guild_locale;

/**
* @brief Attachment size limit in bytes for this interaction. Will be the discord default if not provided by the interaction.
*/
uint32_t attachment_size_limit;

/**
* @brief Cache policy from cluster.
*/
Expand Down
7 changes: 6 additions & 1 deletion src/dpp/slashcommand.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ slashcommand& slashcommand::add_option(const command_option &o)
return *this;
}

interaction::interaction() : application_id(0), type(0), guild_id(0), channel_id(0), message_id(0), version(0), cache_policy(cache_policy::cpol_default) {
interaction::interaction() : application_id(0), type(0), guild_id(0), channel_id(0), message_id(0), version(0), attachment_size_limit(DEFAULT_ATTACHMENT_SIZE_LIMIT), cache_policy(cache_policy::cpol_default) {
}

command_interaction interaction::get_command_interaction() const {
Expand Down Expand Up @@ -625,6 +625,11 @@ void from_json(const nlohmann::json& j, interaction& i) {
i.channel_id = snowflake_not_null(&j, "channel_id");
i.guild_id = snowflake_not_null(&j, "guild_id");
i.app_permissions = snowflake_not_null(&j, "app_permissions");
i.attachment_size_limit = int32_not_null(&j, "attachment_size_limit");

if (i.attachment_size_limit == 0) {
i.attachment_size_limit = DEFAULT_ATTACHMENT_SIZE_LIMIT;
}

if (j.contains("channel") && !j.at("channel").is_null()) {
const json& c = j["channel"];
Expand Down