Use the correct minizip-ng header folder#144
Open
uilianries wants to merge 3 commits intobrechtsanders:masterfrom
Open
Use the correct minizip-ng header folder#144uilianries wants to merge 3 commits intobrechtsanders:masterfrom
uilianries wants to merge 3 commits intobrechtsanders:masterfrom
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This reverts commit efd5647.
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
When reviewing the PR conan-io/conan-center-index#28528 for adapting xlsxio to use minizip-ng version, it was noted there is an incompatibility in the project, related to what is generated by minizip-ng.
This PR is a follow-up of a9016eb. The minizip-ng project, when built with the option
MZ_COMPAT=ON, will produce the expected header names, such like:minizip/zip.handminizip/unzip.h, but will not generate them under the folderminizip-ng.When building MinizipNG with the option
MZ_COMPAT=OFF, it will produce the folderminizip-ng, but it does not contain those expected headers likezip.handunzip.hbecause it is not in compatible mode.To be sure about what I'm pointing to, you can see this build log that contains minizip 4.0.6, 4.0.7, 4.0.8 and 4.0.10 build output, with
MZ_COMPAT=ON/OFF. The install step makes it clear about the folder name: minizip-build.logThis PR expects minizip-ng to be built with
MZ_COMPAT=ON, as always was for this project, then it uses that advantage to keep the same included headers for minizip and minizip-ng, as a result, it no longer needsUSE_MINIZIP_NGcompiler definition.Plus, the MizipNG project provides its official
minizip-config.cmakefile (you can see in the build logs), with the CMake targetMINIZIP::minizip, which makes it much safer when consuming instead of CMake variables.Talking about CMake variables, I also bumped the requires CMake version to 3.15, because <=3.5 is in order to be deprecated. There is a big warning message for newer CMake versions like 4.x (See the official information at https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-version)
As GitHub Actions does not build using minizip-ng, I made it locally using Conan to make sure it will not break. Here is my local build log: xlsxio-0.2.37-dev-linux-gcc11-static-minizipng.log
In case the scope of this PR is big, please tell me then I can split it to make the review easier.
Regards.