Skip to content

[xlsxio] Limit to use minizip-ng 4.0.7 as requirement to avoid incompatibility#28528

Open
uilianries wants to merge 1 commit intoconan-io:masterfrom
uilianries:xlsxio/fix-minizipng-compat
Open

[xlsxio] Limit to use minizip-ng 4.0.7 as requirement to avoid incompatibility#28528
uilianries wants to merge 1 commit intoconan-io:masterfrom
uilianries:xlsxio/fix-minizipng-compat

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Oct 7, 2025

Summary

Changes to recipe: xlsxio/0.2.34

Motivation

When reviewing #28004 and testing the side effects of having minizip-ng/mz_compatibility=True, the package for xlsxio failed to be built using minizip/4.0.10:

xlsxio_write.c:16:14: fatal error: mz_compat.h: No such file or directory
16 | # include <mz_compat.h>

Full build log: xlsxio-0.2.34-linux-gcc11-static-minizipng.log

As minizip-ng is an optional dependency, it passed by the CI without warnings, but users are broken in case using it due version range not limiting to the proper version.

The minizip-ng 4.0.8 passed by a transformation, including replacing the mz_compat.h by a few headers like minizip-ng/zip.h

Further details about that release can be found in their changelog: https://github.com/zlib-ng/minizip-ng/releases/tag/4.0.8

The specific commit that changed the minizip-ng behavior is zlib-ng/minizip-ng@7df56f7. The release 4.0.8 is a patch version, but it looks a breaking change anyway.

Details

This PR limits the xlsxio/0.2.34 to use minizip-ng only until 4.0.7, which is safe:

xlsxio-0.2.34-linux-gcc11-static-patched.log

I also removed the logic checking the minimal version, as we only have 0.2.34 available in the recipe.

However, doing a quick look at xlsxio/0.2.36 (not in CCI yet), it has already adapted to use newer releases of minizip-ng, which will result in further changes in the recipe.


Signed-off-by: Uilian Ries <uilianr@jfrog.com>
@jcar87
Copy link
Contributor

jcar87 commented Dec 8, 2025

This was a bit confusing because we do not currently have minizip-ng newer than 4.0.7 - so while it is a conservative and reasonable fix - nobody is experiencing it if they are using vanilla Conan Center.

I would probably consider just refactoring this PR to publish the newer xlxsio version that already fixes this: brechtsanders/xlsxio@a9016eb
and backport if appropriate

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comment above)

@uilianries
Copy link
Member Author

This was a bit confusing because we do not currently have minizip-ng newer than 4.0.7 - so while it is a conservative and reasonable fix - nobody is experiencing it if they are using vanilla Conan Center.

I would probably consider just refactoring this PR to publish the newer xlxsio version that already fixes this: brechtsanders/xlsxio@a9016eb and backport if appropriate

That commit is not enough because minzip-ng provides compatible headers under the folder minizip, but not minizip-ng.

I just sent the PR brechtsanders/xlsxio#144 to the upstream, so we can bump to a new future release using the minizip-ng support correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants