Skip to content

Conversation

@nwt
Copy link
Member

@nwt nwt commented Nov 17, 2025

They haven't caught a problem in a long time.

They haven't caught a problem in a long time.
@nwt nwt merged commit 4e7d8c1 into main Nov 17, 2025
2 checks passed
@nwt nwt deleted the remove-make-output-check branch November 17, 2025 16:02
@philrz
Copy link
Contributor

philrz commented Nov 17, 2025

FWIW, #1065 was when this was originally added.

To summarize, it originated in time when we were frequently changing the data formats and wanted a way to know if we'd made a change by accident that would affect users that had started saving data in our formats. Since it read/wrote values of most types in all supported formats, over time it also found a couple panics specific to input/output of certain values/formats. However, as noted above by @nwt it hadn't found any problems in a while, plus there was overhead related to making its test keep passing after it started "failing" due to benign changes. Meanwhile we have a lot more ztests that provide test coverage, and with few exceptions our data formats have been holding still. It was a fine time to retire it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants