Refactor POPULAR_BABY_NAMES_2021 to use Rc<RefCell> instead of Arc<Mutex>#24
Merged
brndnmtthws merged 3 commits intobrndnmtthws:mainfrom Nov 27, 2025
Merged
Refactor POPULAR_BABY_NAMES_2021 to use Rc<RefCell> instead of Arc<Mutex>#24brndnmtthws merged 3 commits intobrndnmtthws:mainfrom
brndnmtthws merged 3 commits intobrndnmtthws:mainfrom
Conversation
Contributor
Author
|
Let me know if a comment in |
Owner
|
The build error appears unrelated to your changes, and I fixed it in #26. If you merge or rebase against main, the build should pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
POPULAR_BABY_NAMES_2021global variable to useRc<RefCell<Vec<String>>>instead ofArc<Mutex<Option<Vec<String>>>>. Since the data is only accessed within a single thread, this change removes unnecessary synchronization overhead while preserving interior mutability.Rationale
Rc<RefCell<T>>is more appropriate for single-threaded scenarios.Notes
Most of the file was left untouched to maintain alignment with the book version.