Skip to content

Refactor POPULAR_BABY_NAMES_2021 to use Rc<RefCell> instead of Arc<Mutex> #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brndnmtthws merged 3 commits into from
Nov 27, 2025
Merged

Refactor POPULAR_BABY_NAMES_2021 to use Rc<RefCell> instead of Arc<Mutex> #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ed1566
Refactor POPULAR_BABY_NAMES_2021 to use Rc<RefCell> instead of Arc<Mu…
DannyCeb Nov 25, 2025
f10afb3
change to run the github CI action
DannyCeb Nov 26, 2025
dea3086
Merge branch 'brndnmtthws:main' into main
DannyCeb Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions ch04/global-vars/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
use lazy_static::lazy_static;
use once_cell::sync::Lazy;
use static_init::dynamic;
use std::cell::OnceCell;
use std::sync::{Arc, Mutex};
use std::cell::{OnceCell, RefCell};
use std::rc::Rc;

thread_local! {
static POPULAR_BABY_NAMES_2021: Arc<Mutex<Option<Vec<String>>>> =
Arc::new(Mutex::new(None));
static POPULAR_BABY_NAMES_2021: Rc<RefCell<Vec<String>>> = Rc::new(RefCell::new(Vec::new()));
}

lazy_static! {
Expand Down Expand Up @@ -38,14 +37,15 @@ static POPULAR_BABY_NAMES_2018: Vec<String> = vec![
];

fn main() {
let arc = POPULAR_BABY_NAMES_2021.with(|arc| arc.clone());
let mut inner = arc.lock().expect("unable to lock mutex");
*inner = Some(vec![
String::from("Olivia"),
String::from("Liam"),
String::from("Emma"),
String::from("Noah"),
]);
POPULAR_BABY_NAMES_2021.with(|rc| {
rc.borrow_mut().extend([
"Olivia".to_string(),
"Liam".to_string(),
"Emma".to_string(),
"Noah".to_string(),
]);
});

let popular_baby_names_2017: OnceCell<Vec<String>> = OnceCell::new();
popular_baby_names_2017.get_or_init(|| {
vec![
Expand All @@ -56,7 +56,8 @@ fn main() {
]
});

println!("popular baby names of 2021: {:?}", *inner);
let names = POPULAR_BABY_NAMES_2021.with(|rc| rc.borrow().clone());
println!("popular baby names of 2021: {:?}", names);

println!("popular baby names of 2020: {:?}", *POPULAR_BABY_NAMES_2020);

Expand Down