CI Test Failures #113
Merged
CI Test Failures #113
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitribouniol
commented
Oct 9, 2025
| rawID: credentialID, | ||
| attestationObject: attestationObject | ||
| ) | ||
| #expect(credential != nil) |
There was a problem hiding this comment.
Turns out this could never be nil 🤪
There was a problem hiding this comment.
Yep. I'm guessing early versions of Testing didn't flag it, while 6.1 and 6.2 really didn't like it, while the nightlies because indifferent again.
0xTim
approved these changes
Oct 9, 2025
| rawID: credentialID, | ||
| attestationObject: attestationObject | ||
| ) | ||
| #expect(credential != nil) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed sendable warnings when running tests, and fixed an issue that would cause some test runners to fail.