Skip to content

CI Test Failures #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
+2 −3
Merged

CI Test Failures #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8517b8
Fixed sendable warnings when running tests
dimitribouniol Oct 9, 2025
830cce1
Fixed an issue that would cause some test runners to fail
dimitribouniol Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tests/WebAuthnTests/Utils/TestModels/TestKeyConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@

import Foundation

protocol TestSigner {
protocol TestSigner: Sendable {
static func sign(data: Data) throws -> [UInt8]

static var signature: [UInt8] { get throws }
}

struct TestKeyConfiguration {
struct TestKeyConfiguration: Sendable {
var signer: any TestSigner.Type
var credentialPublicKeyBuilder: TestCredentialPublicKeyBuilder
var authDataBuilder: TestAuthDataBuilder
Expand Down
1 change: 0 additions & 1 deletion Tests/WebAuthnTests/WebAuthnManagerRegistrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,6 @@ struct WebAuthnManagerRegistrationTests {
rawID: credentialID,
attestationObject: attestationObject
)
#expect(credential != nil)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this could never be nil 🤪

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it non optional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I'm guessing early versions of Testing didn't flag it, while 6.1 and 6.2 really didn't like it, while the nightlies because indifferent again.


#expect(credential.id == credentialID.base64EncodedString().asString())
#expect(credential.publicKey == credentialPublicKey)
Expand Down