Clean workspace dev dependencies #1340
Open
+73
−2,122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Greptile OverviewGreptile SummaryCleaned up root workspace
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Root as Root Workspace
participant Core as packages/core
participant Evals as packages/evals
Note over Root: Before: 26 devDependencies
Root->>Core: Move @types/adm-zip, @types/node, adm-zip, chalk, esbuild
Root->>Evals: Move braintrust, string-comparison
Note over Root: Remove 19 unused deps<br/>(langchain, cheerio, express, etc.)
Note over Root: After: 9 devDependencies
Note over Core: +5 devDependencies
Note over Evals: +2 devDependencies
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (all 3 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/evals/package.json">
<violation number="1" location="packages/evals/package.json:24">
P1: `braintrust` is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.</violation>
<violation number="2" location="packages/evals/package.json:25">
P1: `chalk` is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.</violation>
<violation number="3" location="packages/evals/package.json:26">
P1: `string-comparison` powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| "devDependencies": { | ||
| "braintrust": "^0.4.7", | ||
| "chalk": "^5.4.1", | ||
| "string-comparison": "^1.3.0", |
There was a problem hiding this comment.
P1: string-comparison powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 26:
<comment>`string-comparison` powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.</comment>
<file context>
@@ -21,6 +21,9 @@
"devDependencies": {
+ "braintrust": "^0.4.7",
+ "chalk": "^5.4.1",
+ "string-comparison": "^1.3.0",
"tsx": "^4.10.5"
}
</file context>
| }, | ||
| "devDependencies": { | ||
| "braintrust": "^0.4.7", | ||
| "chalk": "^5.4.1", |
There was a problem hiding this comment.
P1: chalk is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 25:
<comment>`chalk` is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.</comment>
<file context>
@@ -21,6 +21,9 @@
},
"devDependencies": {
+ "braintrust": "^0.4.7",
+ "chalk": "^5.4.1",
+ "string-comparison": "^1.3.0",
"tsx": "^4.10.5"
</file context>
| "zod": "^4.1.8" | ||
| }, | ||
| "devDependencies": { | ||
| "braintrust": "^0.4.7", |
There was a problem hiding this comment.
P1: braintrust is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 24:
<comment>`braintrust` is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.</comment>
<file context>
@@ -21,6 +21,9 @@
"zod": "^4.1.8"
},
"devDependencies": {
+ "braintrust": "^0.4.7",
+ "chalk": "^5.4.1",
+ "string-comparison": "^1.3.0",
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
These dev dependencies don't belong here. Some are no longer used, some should go into their respective packages
what changed
Moved dev dependencies to respective packages and removed unused ones
test plan
Summary by cubic
Moved dev dependencies from the workspace root into the packages that use them and removed unused ones. This reduces install bloat and clarifies ownership of tools.
Why:
What:
Test Plan:
Written for commit c0b94c0. Summary will update automatically on new commits.