Skip to content

Clean workspace dev dependencies #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+73 −2,122
Open

Clean workspace dev dependencies #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd85617
Clean workspace dev dependencies
miguelg719 Dec 3, 2025
c0b94c0
add back necessary deps
miguelg719 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,35 +27,9 @@
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.9",
"@eslint/js": "^9.16.0",
"@langchain/community": "^1.0.0",
"@langchain/core": "^0.3.40",
"@langchain/langgraph": "^1.0.1",
"@langchain/openai": "^0.4.4",
"@playwright/test": "^1.42.1",
"@types/adm-zip": "^0.5.7",
"@types/cheerio": "^0.22.35",
"@types/express": "^4.17.21",
"@types/node": "^20.11.30",
"@types/ws": "^8.5.13",
"adm-zip": "^0.5.16",
"autoevals": "^0.0.64",
"braintrust": "^0.4.7",
"chalk": "^5.4.1",
"cheerio": "^1.0.0",
"chrome-launcher": "^1.2.0",
"chromium-bidi": "^0.10.0",
"esbuild": "^0.21.4",
"eslint": "^9.16.0",
"express": "^4.21.0",
"globals": "^15.13.0",
"multer": "^1.4.5-lts.1",
"patchright-core": "^1.55.2",
"playwright-core": "^1.54.1",
"prettier": "^3.2.5",
"puppeteer-core": "^22.8.0",
"string-comparison": "^1.3.0",
"tsup": "^8.2.1",
"tsx": "^4.10.5",
"turbo": "^2.5.8",
"typescript": "^5.2.2",
"typescript-eslint": "^8.17.0"
Expand Down
6 changes: 6 additions & 0 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@
},
"devDependencies": {
"@playwright/test": "^1.42.1",
"@types/adm-zip": "^0.5.7",
"@types/node": "^20.11.30",
"@types/ws": "^8.5.13",
"adm-zip": "^0.5.16",
"chalk": "^5.4.1",
"esbuild": "^0.21.4",
"eslint": "^9.16.0",
"prettier": "^3.2.5",
"tsup": "^8.2.1",
Expand Down
3 changes: 3 additions & 0 deletions packages/evals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
"zod": "^4.1.8"
},
"devDependencies": {
"braintrust": "^0.4.7",
Copy link

@cubic-dev-ai cubic-dev-ai bot Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: braintrust is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 24:

<comment>`braintrust` is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.</comment>

<file context>
@@ -21,6 +21,9 @@
     &quot;zod&quot;: &quot;^4.1.8&quot;
   },
   &quot;devDependencies&quot;: {
+    &quot;braintrust&quot;: &quot;^0.4.7&quot;,
+    &quot;chalk&quot;: &quot;^5.4.1&quot;,
+    &quot;string-comparison&quot;: &quot;^1.3.0&quot;,
</file context>
Fix with Cubic

Copy link
Collaborator Author

@miguelg719 miguelg719 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package is not published so install will still hit dev

Copy link

@cubic-dev-ai cubic-dev-ai bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I've saved this as a new learning to improve future reviews.

"chalk": "^5.4.1",
Copy link

@cubic-dev-ai cubic-dev-ai bot Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: chalk is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 25:

<comment>`chalk` is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.</comment>

<file context>
@@ -21,6 +21,9 @@
   },
   &quot;devDependencies&quot;: {
+    &quot;braintrust&quot;: &quot;^0.4.7&quot;,
+    &quot;chalk&quot;: &quot;^5.4.1&quot;,
+    &quot;string-comparison&quot;: &quot;^1.3.0&quot;,
     &quot;tsx&quot;: &quot;^4.10.5&quot;
</file context>
Fix with Cubic

"string-comparison": "^1.3.0",
Copy link

@cubic-dev-ai cubic-dev-ai bot Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: string-comparison powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 26:

<comment>`string-comparison` powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.</comment>

<file context>
@@ -21,6 +21,9 @@
   &quot;devDependencies&quot;: {
+    &quot;braintrust&quot;: &quot;^0.4.7&quot;,
+    &quot;chalk&quot;: &quot;^5.4.1&quot;,
+    &quot;string-comparison&quot;: &quot;^1.3.0&quot;,
     &quot;tsx&quot;: &quot;^4.10.5&quot;
   }
</file context>
Fix with Cubic

"tsx": "^4.10.5"
}
}
Loading
Loading