Skip to content

If assigning 'inplace', and there's a value, assign globally#2530

Merged
brucemiller merged 1 commit intomasterfrom
unset-box-patch
Mar 13, 2025
Merged

If assigning 'inplace', and there's a value, assign globally#2530
brucemiller merged 1 commit intomasterfrom
unset-box-patch

Conversation

@brucemiller
Copy link
Copy Markdown
Owner

Patch following discussion in #2527. If we assign "inplace", with an actual value (as opposed to clearing), and there is no previous assignment, we'll assign globally. A reasonable default, if we end up ever needing the feature.

@brucemiller brucemiller requested a review from dginev March 12, 2025 13:50
Copy link
Copy Markdown
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for @xworld21 to review, I would still prefer that code path disabled with a warning.

@dginev dginev requested review from dginev and removed request for dginev March 12, 2025 15:26
@brucemiller
Copy link
Copy Markdown
Owner Author

For some reason, I can't add @xworld21 to reviewr

@dginev
Copy link
Copy Markdown
Collaborator

dginev commented Mar 12, 2025

@brucemiller same, I think the repository settings are too restrictive. In fact I know they are, because I don't have any access to them - you are the only one who can investigate there.

It's the "Settings" tab at the rightmost top of the repo page. See #2523 as a related problem to settings.

@brucemiller brucemiller requested review from dginev and removed request for dginev March 13, 2025 14:05
@brucemiller
Copy link
Copy Markdown
Owner Author

Ah, the docs are somewhat hard to parse, but I think the problem is that for free accounts, you can only request one reviewer. And I haven't discovered a way to UN-request the review from @dginev

@dginev
Copy link
Copy Markdown
Collaborator

dginev commented Mar 13, 2025

That's not quite it, since you can't request external reviews on any of the other PRs that don't have a reviewer set either, for example #2364

Copy link
Copy Markdown
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR code matches its description.

@brucemiller brucemiller merged commit 9ef43f8 into master Mar 13, 2025
26 checks passed
@brucemiller brucemiller deleted the unset-box-patch branch March 13, 2025 19:14
@xworld21
Copy link
Copy Markdown
Contributor

Good that you didn't wait for my review: I don't understand frames at all...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants