Skip to content

If assigning 'inplace', and there's a value, assign globally #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brucemiller merged 1 commit into from
Mar 13, 2025
Merged

If assigning 'inplace', and there's a value, assign globally #2530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/LaTeXML/Core/State.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,13 @@ sub assign_internal {
elsif ($scope eq 'inplace') { # Special case for \box & friends
if (exists $$self{$table}{$key}) { # If the value was previously assigned AT ALL
$$self{$table}{$key}[0] = $value; } # Simply replace the value in its frame
else { # Otherwise, push new value, like local
$$self{undo}[0]{$table}{$key} = 1;
elsif ($value) { # Otherwise, push new value, globally
my $frame;
my @frames = @{ $$self{undo} };
while (@frames) { # Find top frame
$frame = shift(@frames);
last if $$frame{_FRAME_LOCK_}; }
$$frame{$table}{$key} = 1;
unshift(@{ $$self{$table}{$key} }, $value); } } # And push new binding.
else {
assign_internal($self, 'stash', $scope, [], 'global') unless $$self{stash}{$scope}[0];
Expand Down Expand Up @@ -841,7 +846,7 @@ determines how the assignment is made. The allowed values and their implication
global : global assignment.
local : local assignment, within the current grouping.
undef : global if \global preceded, else local (default)
inplace : assigns in same frame as previously set (for unsetting \box)
inplace : assigns in same frame as previously set (for unsetting \box), or globally
<name> : stores the assignment in a `scope' which
can be loaded later.

Expand Down