remove final permutedims() in binary_einsum#58
remove final permutedims() in binary_einsum#58starsfordummies wants to merge 5 commits intomasterfrom
Conversation
|
Oh, so we could put something that reorders the indices instead of the inner array, right? |
mofeing
left a comment
There was a problem hiding this comment.
I'm thinking that we can probably better avoid kwargs and directly use the ScopedValue as a performance configuration. Tell me if it's difficult for you and I can do it.
|
|
||
|
|
yeah, kind of. we wouldn't really force an order doing |
|
I still don't know if it makes sense to add a global option to force contract to return indices in a given order, when in most cases it decides the order by itself - know what I mean? |
maybe I don't fully understand the logic in all those index sets in binary_einsum, but if we can get rid of the final permutedims() that would give a significant speedup. The tests hopefully will help see if I'm wrong