Fix unused dependencies on type filters for buf generate#3695
Merged
emcfarlane merged 2 commits intomainfrom Mar 25, 2025
Merged
Fix unused dependencies on type filters for buf generate#3695emcfarlane merged 2 commits intomainfrom
emcfarlane merged 2 commits intomainfrom
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes unused dependencies when a type filter is applied for
buf generate. The unused deps are validated when unmarshalling an image here. For a filtered image there are no unused deps as all unused are pruned. Test have been updated to capture the validation.The fix has also been applied in #3624 .