Skip to content

Fix type filter import filtering for options#3727

Merged
emcfarlane merged 2 commits intomainfrom
ed/fixDepOptionResolving
Mar 31, 2025
Merged

Fix type filter import filtering for options#3727
emcfarlane merged 2 commits intomainfrom
ed/fixDepOptionResolving

Conversation

@emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Mar 31, 2025

This fixes type filter import filtering for options. The parent file was incorrectly referred as the importer leading to unused imports for the file. This could be inconsistent depending on the order the types were resolved.

Fixes #3725

@emcfarlane emcfarlane requested a review from doriable March 31, 2025 22:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 31, 2025, 10:42 PM

@emcfarlane emcfarlane merged commit 42f8b2b into main Mar 31, 2025
11 checks passed
@emcfarlane emcfarlane deleted the ed/fixDepOptionResolving branch March 31, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-deterministic file dependencies

2 participants