Added features to the Makefile and Activation event#427
Closed
Added features to the Makefile and Activation event#427
Conversation
…t present, and to always compile. Added a handleProtoFileOpened event to check and ensure the language server is running. If not, it starts it up. This helps in dev mode if a previous extension version is there. The impact is minimal if the server is running (it exits)
|
|
timostamm
reviewed
Aug 11, 2025
doriable
reviewed
Aug 11, 2025
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
Thank you for putting this up!
doriable
reviewed
Aug 13, 2025
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
Just a couple of small things, thank you!
doriable
approved these changes
Aug 14, 2025
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
Going to approve, just left a small nit -- I'll investigate biome + unused imports ^^" Thank you!
| import { stopLanguageServer } from "./commands/stop-lsp"; | ||
| import { log } from "./log"; | ||
| import { activateStatusBar, deactivateStatusBar } from "./status-bar"; | ||
| import { bufState } from "./state"; |
Member
There was a problem hiding this comment.
This import should be unused now ^^" Hmm, unfortunate that CI doesn't catch that... o_o
Author
|
Going to close this as I think most of these things were either my mistake or already dealt with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added features to the Makefile to install npm packages on build if not present, and to always compile. Added a
handleProtoFileOpenedevent to check and ensure the language server is running. If not, it starts it up. This helps in dev mode if a previous extension version is there. The impact is minimal if the server is running (it exits).Please check the Makefile to be sure it meets with your standards. Hope this is helpful!