Skip to content

Added features to the Makefile and Activation event #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robconery wants to merge 3 commits into from
Closed

Added features to the Makefile and Activation event #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5de3af4
Added features to the Makefile to install npm packages on build if no…
Aug 8, 2025
004e7ed
Added changes per PR review
Aug 11, 2025
e77f33c
Removed line in package.json and changed prepackage to prepublish
Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
.DEFAULT_GOAL := package

.PHONY: package
package:
.PHONY: compile package
package: compile
npm run package

.PHONY: install
install:
npm install

node_modules: package-lock.json
npm ci

.PHONY: compile
compile: node_modules
npm run compile
2 changes: 2 additions & 0 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { startLanguageServer } from "./commands/start-lsp";
import { stopLanguageServer } from "./commands/stop-lsp";
import { log } from "./log";
import { activateStatusBar, deactivateStatusBar } from "./status-bar";
import { bufState } from "./state";
Copy link
Member

@doriable doriable Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import should be unused now ^^" Hmm, unfortunate that CI doesn't catch that... o_o


/**
* activate is the entrypoint for activating the extension.
Expand All @@ -15,6 +16,7 @@ export async function activate(ctx: vscode.ExtensionContext) {
ctx.subscriptions.push(
vscode.workspace.onDidChangeConfiguration(handleOnDidConfigChange)
);

await installBuf.execute();
}

Expand Down
Loading