[2.x] Uses NullableShutdownStrategy on tests#493
Open
nunomaduro wants to merge 2 commits intobugsnag:masterfrom
Open
[2.x] Uses NullableShutdownStrategy on tests#493nunomaduro wants to merge 2 commits intobugsnag:masterfrom
NullableShutdownStrategy on tests#493nunomaduro wants to merge 2 commits intobugsnag:masterfrom
Conversation
This was referenced Sep 27, 2022
|
Hi @nunomaduro - could you explain a bit more about your use case here please? 600 tests sound like a lot to have a direct dependency on Bugsnag. Is there no way for you to isolate those tests from Bugsnag and/or mock Bugsnag to avoid that dependency? |
Member
|
Hi @nunomaduro, have you seen the message from luke-belton above? We would really need to understand your use case in order to consider this PR. |
|
@luke-belton @johnkiely1 I think this originated in this issue: laravel/framework#44214 |
Member
|
We will look to review this PR when priorities allow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a memory leak of this package with Laravel's unit tests, where the
Illuminate\Foundation\Applicationinstance is being leaked to PHP's internal shutdown function.In other words, Laravel often creates application instances during tests, and bugsnag is registering (for each new test case) a new shutdown function with those application instances.
With this fix, we're able to decrease the memory usage of a 600 test suite by 14% percent:
Note, #65 equally needs to merged and tagged.