Skip to content

[2.x] Uses NullableShutdownStrategy on tests #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[2.x] Uses NullableShutdownStrategy on tests #493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
022d5cf
Uses `NullableShutdownStrategy` on tests
nunomaduro Sep 27, 2022
c91f073
Adds `class_exists` to avoid bumping versions
nunomaduro Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/BugsnagServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Bugsnag\PsrLogger\BugsnagLogger;
use Bugsnag\PsrLogger\MultiLogger as BaseMultiLogger;
use Bugsnag\Report;
use Bugsnag\Shutdown\NullableShutdownStrategy;
use DateTime;
use Illuminate\Auth\GenericUser;
use Illuminate\Contracts\Container\Container;
Expand Down Expand Up @@ -191,7 +192,14 @@ public function register()
{
$this->app->singleton('bugsnag', function (Container $app) {
$config = $app->config->get('bugsnag');
$client = new Client(new Configuration($config['api_key']), new LaravelResolver($app), $this->getGuzzle($config));

$shutdownStrategy = null;

if (class_exists(NullableShutdownStrategy::class) && $app instanceof LaravelApplication && $app->runningUnitTests()) {
$shutdownStrategy = new NullableShutdownStrategy();
}

$client = new Client(new Configuration($config['api_key']), new LaravelResolver($app), $this->getGuzzle($config), $shutdownStrategy);

$this->setupCallbacks($client, $app, $config);
$this->setupPaths($client, $app, $config);
Expand Down