feat: adding handler middleware to ensure otel attributes are set #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the work in open-telemetry/semantic-conventions#2083 with the goal to be standardised monitoring of this MCP server.
wolfeidau
force-pushed
the
feat_otel_hooks
branch
from
2e1c64e to
571c51a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds standardized OpenTelemetry (OTEL) monitoring to the MCP server by implementing configurable trace exporters and comprehensive instrumentation hooks. The changes support different exporter types (OTLP, gRPC, noop) and add tracing middleware for tool and resource handlers.
- Added configurable OTEL exporter support with OTLP, gRPC, and noop options
- Implemented tracing middleware for tool and resource handlers with structured logging
- Updated test coverage to validate different exporter configurations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/trace/trace.go | Added configurable exporter factory, tracing middleware functions, and updated hooks |
| pkg/trace/trace_test.go | Enhanced tests to validate different exporter types and improved assertions |
| pkg/server/mcp.go | Integrated tracing middleware for tool and resource handlers |
| cmd/buildkite-mcp-server/main.go | Added OTEL exporter configuration and improved console logging for interactive terminals |
| internal/commands/stdio.go | Added startup logging message |
| go.mod | Moved go-isatty dependency from indirect to direct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wolfeidau
changed the title
wolfeidau
force-pushed
the
feat_otel_hooks
branch
2 times, most recently
from
904afef to
d508fb3
Compare
catkins
approved these changes
Sep 16, 2025
* improved the logging for local interactive users * added a new outer tool span which holds the semantic fields * sorted out error reporting for tools and resources * fixed the annoying error printed for tracing as I wasn't configuring it correctly
wolfeidau
force-pushed
the
feat_otel_hooks
branch
from
d508fb3 to
0c524cd
Compare
catkins
approved these changes
Sep 16, 2025
|
🚀 |
catkins
reviewed
Sep 16, 2025
So by default the logger is info, json when non intractive, pretty when interactive. If you enable debug it level is changed to reflect this. To simplify things the global logger is added to the MCP context used by the STDIO server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the work in open-telemetry/semantic-conventions#2083 with the goal to be standardised monitoring of this MCP server.