fix(deploy): no need for quoting around filename_pattern input val
#555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hack3rvaillant
approved these changes
Aug 26, 2025
paulRbr
force-pushed
the
fix-filename-pattern
branch
from
8415079 to
774d855
Compare
Not sur why I added some quotes around the newly introduced
`filename_pattern` input, as we don't quote any of the other input
values.
This led to a bug of double single quotes, thus the default pattern
for the GH action to be the litteral `'{slug}-api'` (with the single
quotes).
Sorry for that!
paulRbr
force-pushed
the
fix-filename-pattern
branch
from
774d855 to
dbd0f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sur why I added some quotes around the newly introduced
filename_patterninput, as we don't quote any of the other inputvalues.
This led to a bug of double single quotes, thus the default pattern
for the GH action to be the litteral
'{slug}-api'(with the singlequotes).
Sorry for that!